MLE-32018 : add ML11 nightly to PDC - #472
Merged
Merged
Conversation
rwinieski
requested review from
barkhachoithani,
pengzhouml and
vitalykorolev
and
a lite review from Copilot
August 20, 2026 09:02
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Jenkins pipeline publishing logic so MarkLogic 11 nightly Docker images are also pushed to PDC (in addition to the existing MarkLogic 12 behavior), aligning the CI publish step with the goal of making ML11 nightly available in PDC.
Changes:
- Removed the
marklogicVersion == "12"guard around publishing to the Sandbox PDC ACR so ML11 nightlies are published there as well. - Keeps the existing image tagging scheme for PDC (
${marklogicVersion}-${dockerImageType}and${marklogicVersion}-${dockerImageType}-${dockerVersion}).
Suppressed comments (1)
Jenkinsfile:449
- After removing the version guard, the Sandbox PDC publish block is now indented one level deeper than the surrounding code, which hurts readability and looks like a leftover from the removed
ifblock.
// Publish to private ACR repositories that are used by PDC.
// Publish to Sandbox PDC registry
withCredentials([usernamePassword(credentialsId: 'PDC_SANDBOX_USER', passwordVariable: 'docker_password', usernameVariable: 'docker_user')]) {
sh """
echo "${docker_password}" | docker login --username ${docker_user} --password-stdin ${pdcSbRegistry}
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
vitalykorolev
approved these changes
Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add ML11 Nighty build to PDC
Checklist:
Owner:
JIRA_ID as part of branch/PR name
Rebase the branch with upstream
Squashed all commits into a single commit
Added Tests
Reviewer:
Reviewed Tests
Added to Release Wiki/Jira