fix(marko-skills): derive scaffold vendor from project dir, never marko#126
Merged
Merged
Conversation
The create-module skill led with `marko/payment` as the composer-name example, so the agent surfaced `marko/` as the default vendor when scaffolding a module inside an application project. The marko vendor is reserved for packages contributed to the framework monorepo — an app's own modules/plugins must use the project's vendor. Both marko-skills skills now instruct: derive the vendor from the host project's root directory name (e.g. a project in ~/Sites/acme -> vendor acme, namespace Acme), never hardcode `marko`, and do NOT read it from composer.json `name` (a skeleton-derived project still carries `marko/skeleton` there, so the directory name is the reliable signal). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When scaffolding a module/plugin inside an application project, the
marko-skillsskills suggested themarko/vendor (e.g.marko/payment→Marko\Payment). That's wrong for an implementation — themarkovendor is reserved for packages contributed to the framework monorepo itself. An app's modules must use the project's own vendor.Fix
Both skills (
create-module,create-plugin) now instruct the agent to:{{vendor}}from the host project's root directory name (a project in~/Sites/acme→ vendoracme, namespaceAcme).markoas the vendor for an application module/plugin (only valid inside the marko monorepo, whose root containspackages/core/).composer.jsonname— a project scaffolded frommarko/skeletonstill carriesmarko/skeletonthere, so the directory name is the reliable signal.Testing
packages/claude-pluginssuite green: 71 passed. Examples use the conventionalacmeplaceholder (matching existing test fixtures).🤖 Generated with Claude Code