Skip to content

Add tab key support to contextual menu, and add an aria-label (mathjax/MathJax#3609) - #1569

Merged
dpvc merged 2 commits into
developfrom
issue3609
Sep 24, 2026
Merged

dpvc merged 2 commits into
developfrom
issue3609

Conversation

@dpvc

@dpvc dpvc commented Sep 16, 2026

Copy link
Copy Markdown
Member

This PR adds a check for the Tab key in the key event handler and unposts the message when that occurs. It also adds an ARIA label to the menu, as requested in mathjax/MathJax#3609. As we know, the menu code needs an overhaul, which should be done after it is moved into the MathJax-src repository.

Resolves issue mathjax/MathJax#3609.

@dpvc
dpvc requested a review from zorkow September 16, 2026 19:29
@dpvc dpvc added this to the v4.2 milestone Sep 16, 2026
@codecov

codecov Bot commented Sep 16, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.13%. Comparing base (91b8038) to head (83b3071).
⚠️ Report is 17 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1569   +/-   ##
========================================
  Coverage    87.12%   87.13%           
========================================
  Files          392      392           
  Lines        89187    89213   +26     
  Branches      5063     5067    +4     
========================================
+ Hits         77706    77732   +26     
  Misses       11481    11481           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@zorkow zorkow left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one left over logging. Otherwise fine.

Comment thread ts/ui/menu/MJContextMenu.ts Outdated
@dpvc dpvc changed the title Add tab key support to contextual menu, and add an aria-label Add tab key support to contextual menu, and add an aria-label (mathjax/MathJax#3609) Sep 24, 2026
@dpvc
dpvc merged commit 19ef36f into develop Sep 24, 2026
1 check passed
@dpvc
dpvc deleted the issue3609 branch September 24, 2026 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants