Allow font family, weight, and style CSS to be inherited by token elements - #1574
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1574 +/- ##
===========================================
- Coverage 87.12% 87.12% -0.01%
===========================================
Files 392 392
Lines 89187 89280 +93
Branches 5063 3378 -1685
===========================================
+ Hits 77706 77784 +78
- Misses 11481 11496 +15 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For an expression like
the font family should affect all three elements that it contains. But currently in MathJax, that is not the case.
This PR fixes that issue and propagates the font family, weight, and style CSS styles of a container to its child nodes. For an
mstyleelement, thefontfamily,fontweightandfontstyleare also propagated. For anmielement with a single character content, the style will be set to italic for the specified font automatically.This inheritance is accomplished by using the
setInheritedAttributes()method. Thefont-family,font-weight, andfont-style, if specified, are moved to the inheritedfontfamily,fontweight, andfontstyleattributes (these are inherited values, not explicit attributes, so don't show up in the MathML output directly). The output jax wrapper'sgetVariant()method then picks these up and uses them when determine the math variant to use (which can be an explicit font). This handling is simplified a bit as well.