Line Diagram | Guide Links - #3485
Open
lvachon1 wants to merge 4 commits into
Open
Conversation
…at renders the correct guides given a route.
lvachon1
marked this pull request as ready for review
September 9, 2026 19:02
smartling-github-connector
Bot
added
the
Not Ready for Translation
thecristen
requested changes
Sep 10, 2026
…rmant since the page is only mounted once, this filter should only run once instead of every re-render. Added an empty alt tag to the guide link image since we already have perfectly cromulent link text already. This should hide the image from screen readers as redundant content.
thecristen
approved these changes
Sep 11, 2026
| > | ||
| ⚠️ Watch Your Step ⚠️ | ||
| </marquee> | ||
| <.guides route={@route} guides={@guides} /> |
Collaborator
There was a problem hiding this comment.
nit: You don't need to pass in @route anymore!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Asana Ticket: 💈 Guide links
Implementation
Created a look-up-table of access and beginner guides.
Created a component that renders the correct guides given a route.
We could update this in the future with vanity URLs for these images, but considering the URLs imply they haven't changed since 2018 I don't think it's a pressing matter.
Screenshots
Commuter Rail Guides
Subway Guides
Bus Guides
Silver Line Guides == Bus Guides
Ferry Guides
How to test
Silver Line 1
71 Bus
Red Line
Fall River/New Bedford CR
Loop Ferry
Confirm that the correct guides show up, have the correct images, and link to the correct pages.