feat: migrate to a new slider library#506
Open
stelselim wants to merge 11 commits into
Open
Conversation
stelselim
force-pushed
the
moo-2139/new-slider-range-slider-library
branch
from
1f51207 to
b73765d
Compare
stelselim
force-pushed
the
moo-2139/new-slider-range-slider-library
branch
from
255b0a5 to
519812f
Compare
Contributor
Author
|
TODO: Update cropped screenshots |
Collaborator
There was a problem hiding this comment.
please double check the colors, new ones appear to have a lighter shade of blue.
| expect(component.getAllByText("Invalid")).toHaveLength(2); | ||
| }); | ||
|
|
||
| it("changes the lower value when swiping", () => { |
Collaborator
There was a problem hiding this comment.
why was this test removed?
| expect(component.queryByText("The upper value must be equal or less than the maximum value.")).not.toBeNull(); | ||
| }); | ||
|
|
||
| it("renders with the width of the parent view", () => { |
Collaborator
There was a problem hiding this comment.
why was this test removed?
| const onValueChange = useCallback( | ||
| (values: number[]): void => { | ||
| if (values[0] === null || values[1] === null) { | ||
| if (values[0] === null || values[0] === undefined || values[1] === null || values[1] === undefined) { |
Collaborator
There was a problem hiding this comment.
normally you would want to avoid double equals, but i think in this case it's better to make an exception and replace these checks with == null which should be an equivalent to === null && === undefined
| (values: number[]): void => { | ||
| if ( | ||
| values[0] === null || | ||
| values[0] === undefined || |
Collaborator
There was a problem hiding this comment.
same as above regarding null checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.