[WC-3462] Fix Gallery widget JS actions (Reset Filters, Clear Selection)#2266
Open
r0b1n wants to merge 1 commit into
Open
[WC-3462] Fix Gallery widget JS actions (Reset Filters, Clear Selection)#2266r0b1n wants to merge 1 commit into
r0b1n wants to merge 1 commit into
Conversation
…d Clear Selection Gallery widget has all infrastructure for external JS actions support but never registered event listeners, causing "Reset All Filters" and "Clear Selection" actions to fire into the void. This change: - Creates useGalleryJSActions() helper to register event listeners - Integrates hook into GalleryWidget component - Mirrors datagrid's working implementation pattern Infrastructure already existed: - @mendix/widget-plugin-external-events dependency - Config with name and filtersChannelName - SelectActionsProvider with clearSelection() method - Filter system with CombinedFilter The fix is minimal - just wires up the listeners. Jira: WC-3462
r0b1n
force-pushed
the
fix/WC-3462-gallery-js-actions
branch
from
7871f22 to
ba3b764
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Gallery widget doesn't respond to "Reset All Filters" and "Clear Selection" JS actions. Event listeners were never registered despite having all the required infrastructure.
This fix creates
useGalleryJSActions()helper and integrates it into the widget, mirroring datagrid's working implementation.Testing Required