Skip to content

companion_radio: tear down QSPI peripheral when its init fails (fixes #2827) #2828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
benskigomez wants to merge 1 commit into
base: main
Choose a base branch
from
Open

companion_radio: tear down QSPI peripheral when its init fails (fixes #2827) #2828

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions examples/companion_radio/main.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,18 @@ void setup() {
if (!QSPIFlash.begin()) {
// debug output might not be available at this point, might be too early. maybe should fall back to InternalFS here?
MESH_DEBUG_PRINTLN("CustomLFS_QSPIFlash: failed to initialize");
#if defined(NRF52_PLATFORM)
// A failed QSPI init (e.g. nrfx_qspi_init() returning NRFX_ERROR_TIMEOUT)
// leaves the QSPI peripheral enabled and QSPI_IRQn enabled in the NVIC
// (at priority 0, which is reserved for the SoftDevice) and does NOT clean
// up after itself. That poisons the subsequent SoftDevice enable
// (Bluefruit.begin()), so on BLE builds the node never advertises (#2827).
// Tear the peripheral down so the SoftDevice can start cleanly.
NVIC_DisableIRQ(QSPI_IRQn);
NVIC_ClearPendingIRQ(QSPI_IRQn);
NRF_QSPI->TASKS_DEACTIVATE = 1;
NRF_QSPI->ENABLE = 0;
#endif
} else {
MESH_DEBUG_PRINTLN("CustomLFS_QSPIFlash: initialized successfully");
}
Expand Down