feat: sensor address get and set cli#2831
Open
NickDunklee wants to merge 1 commit into
Open
Conversation
This PR adds the ability to get and set sensor addresses via CLI.
- Can access via CLI on repeater, sensor, room server
- Companion app _should_ be able to probe this data with a code
change, although no way for me to verify
- usage:
- `sensor get addr_BME680`
- `sensor set addr_BME680 0x77`
- Can be used in conjunction with PR 2830 `sensors` CLI
This is part 2 of the sensor CLI PRs, they should both be mergeable
independent of each other.
Tested on:
- RAK19003 repeater via LoRa in official MC app
- RAK19007 repeater via LoRa in official MC app
- RAK19001 sensor via USB
- RAK3401 1W repeater via LoRa in official MC app
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to get and set sensor addresses via CLI.
sensor get addr_BME680sensor set addr_BME680 0x77sensorsCLIThis is part 2 of the sensor CLI PRs, they should both be mergeable independent of each other.
Tested on:
Tried to mimic existing behavior for various platforms, but was only able to test on RAK.