Conversation
Enforce ruff format in CI (previously only ruff check ran), broaden the ruff rule set with PERF/UP/C4/RUF, and add codespell to catch typos in source and docs. Fixes a pre-existing SIM117 nested-with finding surfaced by the check. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
elem.attrs["indices_dtype"] is typed too loosely for np.dtype()'s overloads to resolve; cast it to str, matching the pattern already used for the other reads in this function. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ruff format --check .as a CI step — previously onlyruff checkran, so formatting wasn't actually enforced.PERF,UP,C4,RUF(skippedN/naming since it fights this codebase's deliberate math/AnnData conventions likeX,B,T).codespellas a dev dependency and CI step to catch typos in source/docs.SIM117nested-withfinding intests/test_compression.pythat the check surfaced.Test plan
uv run ruff check .passesuv run ruff format --check .passesuv run codespellpassesuv run pytest -q— 1662 passed, 109 skipped