Fix race condition monitor thread in RegistryMonitor#1604
Merged
Conversation
Add locking to Start and Monitor methods to prevent race conditions with _stoppedEvent. Log monitor thread lifecycle events for better diagnostics. Ensure proper disposal of resources under lock.
Collaborator
Author
|
@microsoft-github-policy-service agree |
gregg-miskelly
requested changes
Jul 1, 2026
gregg-miskelly
left a comment
gregg-miskelly
left a comment
Member
There was a problem hiding this comment.
A few small things to fix
…tAny(new WaitHandle[] { stoppedEvent!, registryChangedEvent });', remove unnessary null check
…ndle.WaitAny(new WaitHandle[] { stoppedEvent!, registryChangedEvent });', remove unnessary null check"
This reverts commit 87affe8.
Remove redundant _stoppedEvent initialization, assuming it is set before use. Simplify WaitHandle.WaitAny call by removing unnecessary null-forgiving operator, relying on prior null check.
gregg-miskelly
approved these changes
Jul 2, 2026
Member
|
@WardenGnaw Do you want to have a quick look before I merge this? |
WardenGnaw
approved these changes
Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a race condition in Microsoft.DebugEngineHost.RegisteryMonitor where if
Stopwas called before the monitor thread started, it would never shutdown.This fixes #1593