docs: fixes comment for Responses property#2891
Open
baywet wants to merge 1 commit into
Open
Conversation
Code Coverage OverviewLanguages: C# C# / code-coverage/dotnetThe overall coverage remains at 88%, unchanged from the branch. Code Coverage is in Public Preview. Learn more and provide us with your feedback. |
|
Youssef1313
reviewed
Jun 15, 2026
| /// REQUIRED. The list of possible responses as they are returned from executing this operation. | ||
| /// The list of possible responses as they are returned from executing this operation. | ||
| /// </summary> | ||
| public OpenApiResponses? Responses { get; set; } = []; |
Member
There was a problem hiding this comment.
What about
Should they be using WriteOptionalObject instead?
Member
Author
There was a problem hiding this comment.
Ahh, here is another clue, it used to be required in v2, as well as v3, but was relaxed in 3.1
Member
Author
There was a problem hiding this comment.
And no, we shouldn't change this. The specification requires the property to be present with a non null value. WriteRequiredObject will write an empty object if the value is null. ({})
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
context dotnet/aspnetcore#67136 (comment)