You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This CVE is affected because our popt source code(v1.6) falls below v1.19
Backported: Yes
The AI patch is incomplete with the upstream patch.
5 . CVE-2026-18743.patch — The original AI-generated backport was incomplete and would not compile. It removed the size_t t variable but left 4 references to t intact, and critically did not fix the actual vulnerability — the flawed maxargvlen reallocation logic ((t > maxargvlen) ? t*2 : maxargvlen*2). The corrected patch now matches upstream commit 3de3d3a from popt PR #137, making all 6 required line changes across both vulnerable code paths in poptConfigFileToString().
rsync.spec — Added -p1 to %autosetup because the patch uses git-format diff paths (a/popt/poptparse.c). Without -p1, RPM's patch invocation cannot strip the a/ prefix and fails with "No file to patch."
Upstream test files skipped — The upstream PR Use Clear Linux optimized packages #137 includes 4 commits; only commit 4/4 (3de3d3a) is the actual CVE fix. Commits 1–3 fix test memory leaks and enable ASAN/UBSAN in popt's own CI, and commit 4 adds popt-specific test data (tests/test3-data/05.input, tests/test3-data/05.answer, tests/testit.sh). These are excluded because:
They belong to popt's standalone test suite (test3 binary), which rsync does not build or ship
rsync's bundled popt copy has no tests/ directory — the files would have nowhere to go
The fix was independently verified against the upstream PoC and 14 additional test vectors in a Docker container using the built RPM, confirming both vulnerable reallocation paths are fixed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Auto Patch rsync for CVE-2026-18743.
Autosec pipeline run -> https://dev.azure.com/mariner-org/mariner/_build/results?buildId=1198192&view=results
CVE-2026-18743 : Single Patch Backporter Pipeline Run -> https://dev.azure.com/mariner-org/mariner/_build/results?buildId=1198195&view=results
Merge Checklist
All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)
*-staticsubpackages, etc.) have had theirReleasetag incremented../cgmanifest.json,./toolkit/scripts/toolchain/cgmanifest.json,.github/workflows/cgmanifest.json)./LICENSES-AND-NOTICES/SPECS/data/licenses.json,./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md,./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)*.signatures.jsonfilessudo make go-tidy-allandsudo make go-test-coveragepassSummary
What does the PR accomplish, why was it needed?
Change Log
Does this affect the toolchain?
YES/NO
Associated issues
Links to CVEs
Test Methodology