Integrate Windows userland broker transport - #1162
Merged
Merged
Conversation
Weiteng Chen (CvvT)
force-pushed
the
weiteng/windows_broker_stacked
branch
4 times, most recently
from
August 12, 2026 22:45
4e5126a to
d4cb0a6
Compare
Weiteng Chen (CvvT)
changed the base branch from
weiteng/windows_broker_transport_refactor
to
weiteng/windows_broker_transport_windows_userland
August 12, 2026 22:45
Weiteng Chen (CvvT)
marked this pull request as draft
August 12, 2026 22:45
Weiteng Chen (CvvT)
force-pushed
the
weiteng/windows_broker_stacked
branch
from
August 12, 2026 23:18
d4cb0a6 to
bbb2981
Compare
Weiteng Chen (CvvT)
force-pushed
the
weiteng/windows_broker_transport_windows_userland
branch
from
August 14, 2026 01:02
18f5eba to
e3c4bd0
Compare
Weiteng Chen (CvvT)
force-pushed
the
weiteng/windows_broker_stacked
branch
from
August 14, 2026 01:03
bbb2981 to
f4f3db6
Compare
Base automatically changed from
weiteng/windows_broker_transport_windows_userland
to
ulitebox
August 14, 2026 01:12
Weiteng Chen (CvvT)
force-pushed
the
weiteng/windows_broker_stacked
branch
from
August 14, 2026 06:19
f4f3db6 to
52aaa8a
Compare
|
🤖 SemverChecks 🤖 Click for details |
Weiteng Chen (CvvT)
marked this pull request as ready for review
August 14, 2026 17:30
Contributor
Author
|
Weidong Cui (@wdcui) I made some changes to the litebox_broker_userland to support Windows. You may want to take a quick look. You can ignore the rest changes to the litebox_runner_linux_on_windows. |
Weidong Cui (wdcui)
approved these changes
Aug 14, 2026
Weidong Cui (wdcui)
left a comment
Member
There was a problem hiding this comment.
The litebox_broker_userland changes look good to me. Thanks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wire the Windows broker transport into the broker and Linux-on-Windows runner. To reduce the duplicate code, refactor the broker to separate platform-agnostic and platform-specific code. Also add end-to-end coverage for static, dynamic, threaded, and concurrent pipe workloads the Linux-on-Windows runner with broker.