Skip to content

Integrate Windows userland broker transport - #1162

Merged
Weiteng Chen (CvvT) merged 10 commits into
uliteboxfrom
weiteng/windows_broker_stacked
Aug 14, 2026
Merged

Integrate Windows userland broker transport#1162
Weiteng Chen (CvvT) merged 10 commits into
uliteboxfrom
weiteng/windows_broker_stacked

Conversation

@CvvT

@CvvT Weiteng Chen (CvvT) commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Wire the Windows broker transport into the broker and Linux-on-Windows runner. To reduce the duplicate code, refactor the broker to separate platform-agnostic and platform-specific code. Also add end-to-end coverage for static, dynamic, threaded, and concurrent pipe workloads the Linux-on-Windows runner with broker.

@CvvT
Weiteng Chen (CvvT) force-pushed the weiteng/windows_broker_stacked branch 4 times, most recently from 4e5126a to d4cb0a6 Compare August 12, 2026 22:45
@CvvT Weiteng Chen (CvvT) changed the title [DRAFT] Support Windows userland broker [DRAFT] Integrate Windows userland broker transport Aug 12, 2026
@CvvT
Weiteng Chen (CvvT) changed the base branch from weiteng/windows_broker_transport_refactor to weiteng/windows_broker_transport_windows_userland August 12, 2026 22:45
@CvvT
Weiteng Chen (CvvT) marked this pull request as draft August 12, 2026 22:45
@CvvT Weiteng Chen (CvvT) changed the title [DRAFT] Integrate Windows userland broker transport Integrate Windows userland broker transport Aug 12, 2026
@CvvT
Weiteng Chen (CvvT) force-pushed the weiteng/windows_broker_stacked branch from d4cb0a6 to bbb2981 Compare August 12, 2026 23:18
@CvvT
Weiteng Chen (CvvT) force-pushed the weiteng/windows_broker_transport_windows_userland branch from 18f5eba to e3c4bd0 Compare August 14, 2026 01:02
@CvvT
Weiteng Chen (CvvT) force-pushed the weiteng/windows_broker_stacked branch from bbb2981 to f4f3db6 Compare August 14, 2026 01:03
Base automatically changed from weiteng/windows_broker_transport_windows_userland to ulitebox August 14, 2026 01:12
@CvvT
Weiteng Chen (CvvT) force-pushed the weiteng/windows_broker_stacked branch from f4f3db6 to 52aaa8a Compare August 14, 2026 06:19
@github-actions

Copy link
Copy Markdown

🤖 SemverChecks 🤖 ⚠️ Potential breaking API changes detected ⚠️

Click for details
--- failure constructible_struct_adds_field: struct exhaustively constructible through public API adds field ---

Description:
A pub struct that could be exhaustively constructed with a literal using only public API has a new pub field, breaking existing exhaustive literals.
        ref: https://doc.rust-lang.org/reference/expressions/struct-expr.html
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/constructible_struct_adds_field.ron

Failed in:
  field CliArgs.broker_control_channel in /home/runner/work/litebox/litebox/litebox_runner_linux_userland/src/lib.rs:84

--- failure struct_pub_field_missing: pub struct's pub field removed or renamed ---

Description:
A publicly-visible struct has at least one public field that is no longer available under its prior name. It may have been renamed or removed entirely.
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/struct_pub_field_missing.ron

Failed in:
  field broker_control_socket of struct CliArgs, previously in file /home/runner/work/litebox/litebox/target/semver-checks/git-ulitebox/09189d4a61d2a794d262d42b8f45ac59f41681a4/litebox_runner_linux_userland/src/lib.rs:84

@CvvT
Weiteng Chen (CvvT) marked this pull request as ready for review August 14, 2026 17:30
@CvvT

Copy link
Copy Markdown
Contributor Author

Weidong Cui (@wdcui) I made some changes to the litebox_broker_userland to support Windows. You may want to take a quick look. You can ignore the rest changes to the litebox_runner_linux_on_windows.

@wdcui Weidong Cui (wdcui) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The litebox_broker_userland changes look good to me. Thanks.

@CvvT
Weiteng Chen (CvvT) added this pull request to the merge queue Aug 14, 2026
Merged via the queue into ulitebox with commit 302d1de Aug 14, 2026
7 checks passed
@CvvT
Weiteng Chen (CvvT) deleted the weiteng/windows_broker_stacked branch August 14, 2026 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants