Join the spawned handles in tests - #1165
Merged
Jay Bosamiya (Microsoft) (jaybosamiya-ms) merged 1 commit intoAug 13, 2026
Merged
Conversation
Jay Bosamiya (Microsoft) (jaybosamiya-ms)
marked this pull request as ready for review
August 12, 2026 23:02
Member
Author
|
Relevant example of failure that this PR should fix: https://github.com/microsoft/litebox/actions/runs/31642623868/job/94268620821 
|
Jay Bosamiya (Microsoft) (jaybosamiya-ms)
enabled auto-merge
August 12, 2026 23:04
|
🤖 SemverChecks 🤖 No breaking API changes detected Note: this does not mean API is unchanged, or even that there are no breaking changes; simply, none of the detections triggered. |
Jay Bosamiya (Microsoft) (jaybosamiya-ms)
deleted the
jayb/deadlock-fix-windows
branch
August 13, 2026 23:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes some rare deadlocks that occur on Windows. Specifically, a still-running thread races with process teardown, which on Windows can in rare cases get stuck. Doing a
joinfixes this. It also helps surface panics if they occur on the thread.