Skip to content

docs(_framework_apis): say check_model is a deliberate no-op #3012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Justin Chu (justinchuby) merged 2 commits into from
Aug 25, 2026
Merged

docs(_framework_apis): say check_model is a deliberate no-op #3012

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b6ca51d
docs(_framework_apis): say check_model is a deliberate no-op
MohammedAlkindi Aug 24, 2026
cbf59a4
docs(_framework_apis): say check_model is a deliberate no-op
MohammedAlkindi Aug 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions onnxscript/_framework_apis/torch_2_5.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,9 +59,13 @@


def check_model(model: ir.Model) -> None:
"""Check the model."""
"""No-op retained for API compatibility.

del model # Unused yet
This intentionally performs no validation. Running the ONNX checker here was
dropped because it can report false positives and adds overhead to export.
"""

del model # Intentionally unused: this function performs no validation.
Comment thread
justinchuby marked this conversation as resolved.
Dismissed


def save_model_with_external_data(
Expand Down
Loading