RCA Perf: Reduce RuntimeFeatureFlags size - #3620
Open
Stefan J. Wernli (swernli) wants to merge 1 commit into
Open
RCA Perf: Reduce RuntimeFeatureFlags size#3620Stefan J. Wernli (swernli) wants to merge 1 commit into
RuntimeFeatureFlags size#3620Stefan J. Wernli (swernli) wants to merge 1 commit into
Conversation
Stefan J. Wernli (swernli)
requested review from
Andrew Casey (amcasey) and
Ian Davis (idavis)
as code owners
August 21, 2026 06:18
Stefan J. Wernli (swernli)
force-pushed
the
swernli/rca-perf-4
branch
2 times, most recently
from
August 21, 2026 17:37
cd3ca6c to
82067d8
Compare
Stefan J. Wernli (swernli)
force-pushed
the
swernli/rca-perf-4
branch
from
August 24, 2026 21:16
82067d8 to
3853adc
Compare
Stefan J. Wernli (swernli)
force-pushed
the
swernli/rca-perf-4
branch
from
August 24, 2026 23:21
3853adc to
0e84afa
Compare
This change removes `QubitAllocation` and `MustBeInlined` feature flags in favor of tracking those via out-of-band hash sets. `QubitAllocation` was only ever used to determine callables whose entire call chain must be inlined, while `MustBeInlined` was about tracking call expressions that must be inlined. By tracking these separately, the `RuntimeFeatureFlags` enum can be reduced back to `u32` and significantly improve RCA perf.
Stefan J. Wernli (swernli)
force-pushed
the
swernli/rca-perf-4
branch
from
August 25, 2026 06:35
0e84afa to
564cfae
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change removes
QubitAllocationandMustBeInlinedfeature flags in favor of tracking those via out-of-band hash sets.QubitAllocationwas only ever used to determine callables whose entire call chain must be inlined, whileMustBeInlinedwas about tracking call expressions that must be inlined. By tracking these separately, theRuntimeFeatureFlagsenum can be reduced back tou32and significantly improve RCA perf.Stack created with GitHub Stacks CLI • Give Feedback 💬