[QRE] Dollar cost calculator - #3680
Open
Dima Fedoriaka (fedimser) wants to merge 9 commits into
Open
Conversation
Dima Fedoriaka (fedimser)
marked this pull request as ready for review
September 2, 2026 22:35
Mathias Soeken (msoeken)
requested changes
Sep 3, 2026
| # Libraries that need to be installed to run Python static checks. | ||
| azure-quantum>=3.8.0 | ||
| cirq-core>=1.6.1,<1.7 | ||
| dataclasses-json>=0.6 |
There was a problem hiding this comment.
Is it worth to add an extra dependency? How would the code change if you don't add this dependency?
Brad Lackey (brad-lackey)
approved these changes
Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DollarCostModelthat represent a mathematical function that takes resource physical estimates (number of qubits and runtime) and returns dollar cost.Targetin the future.CostSpecwhich serves as JSON schema for JSON files that can be used to describe cost specification of a quantum computer.DollarCostModelFromSpecthat implementsDollarCostModelusing cost spec loaded from JSON file.EstimationTable.add_cost_columnthat computes dollar cost for every entry in the table:DollarCostModelthere using keywordcost_model.cost_specwhich must be path to JSON file using schema specified byCostSpec.EstimationTable.add_cost_column.dataclasses-json, for automatic conversion from JSON to CostSpec dataclass.