Skip to content

fix: show non-Java resource toggle in view toolbar #1078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wenyt (wenytang-ms) merged 2 commits into from
Sep 3, 2026
Merged

fix: show non-Java resource toggle in view toolbar #1078

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4e048f1
fix: show non-Java resource toggle in view toolbar
wenytang-ms Sep 3, 2026
a5df265
Merge branch 'main' into fix/promote-non-java-resources-toggle
wenytang-ms Sep 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,12 +253,14 @@
{
"command": "java.project.explorer.showNonJavaResources",
"title": "%contributes.commands.java.project.explorer.showNonJavaResources%",
"category": "Java"
"category": "Java",
"icon": "$(eye)"
},
{
"command": "java.project.explorer.hideNonJavaResources",
"title": "%contributes.commands.java.project.explorer.hideNonJavaResources%",
"category": "Java"
"category": "Java",
"icon": "$(eye-closed)"
},
{
"command": "java.view.package.revealFileInOS",
Expand Down Expand Up @@ -754,12 +756,12 @@
{
"command": "java.project.explorer.showNonJavaResources",
"when": "view == javaProjectExplorer && java:serverMode == Standard && !config.java.project.explorer.showNonJavaResources",
"group": "overflow_10@30"
"group": "navigation@40"
},
{
"command": "java.project.explorer.hideNonJavaResources",
"when": "view == javaProjectExplorer && java:serverMode == Standard && config.java.project.explorer.showNonJavaResources",
"group": "overflow_10@30"
"group": "navigation@40"
},
{
"command": "java.project.rebuild.workspace",
Expand Down
13 changes: 5 additions & 8 deletions test/e2e-plans/java-dep-view-modes.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,11 +182,9 @@ steps:

- id: "hide-non-java"
action: 'clickViewTitleAction "Java Projects" "Hide Non-Java Resources"'
# Real UI path through view-title overflow menu. The menu item label
# toggles based on `config.java.project.explorer.showNonJavaResources`
# (Show vs Hide), and the current state at this point is "showing"
# so the menu surfaces "Hide Non-Java Resources". verifyTreeItem
# checks below are authoritative.
# Direct view-title toolbar action. Its label and icon toggle based on
# `config.java.project.explorer.showNonJavaResources`; the current state
# is "showing", so the toolbar surfaces "Hide Non-Java Resources".

- id: "wait-hide"
action: "wait 5 seconds"
Expand All @@ -203,9 +201,8 @@ steps:
# ── Test 5: show non-Java resources ──
- id: "show-non-java"
action: 'clickViewTitleAction "Java Projects" "Show Non-Java Resources"'
# Real UI path through view-title overflow menu. After hide-non-java
# the toggle now surfaces "Show Non-Java Resources". verifyTreeItem
# below is authoritative.
# After hide-non-java, the same toolbar position surfaces
# "Show Non-Java Resources".

- id: "wait-show"
action: "wait 5 seconds"
Expand Down