agentHost: configure external session discovery - #330541
agentHost: configure external session discovery#330541Benjamin Christopher Simmonds (benibenj) wants to merge 2 commits into
Conversation
|
One or more custom setup steps configured for this repository failed during this Copilot code review run: Setup steps run before each review. If the review above is missing context, or no review was posted at all, the failing step above may be the cause. See the workflow run for failure details, fix your setup steps configuration, and re-request a review. Note You can configure setup steps for Copilot code review separately from Copilot cloud agent with a |
There was a problem hiding this comment.
Pull request overview
Adds configurable discovery and visibility of external Agent Host sessions.
Changes:
- Adds external-session visibility modes and metadata classification.
- Persists session ownership and reconciles connected clients.
- Updates registry and service tests for external metadata.
Show a summary per file
| File | Description |
|---|---|
constants.ts |
Adds the workbench setting key. |
chat.shared.contribution.ts |
Registers visibility mode settings. |
agentSessionRegistry.test.ts |
Tests ownership transitions. |
agentService.test.ts |
Updates expected external metadata. |
agentSessionRegistry.ts |
Exposes persisted ownership. |
agentService.ts |
Filters and reconciles external sessions. |
agentHostStateManager.ts |
Supports retracting surfaced sessions. |
agentHostDatabase.ts |
Persists external classification. |
sessionState.ts |
Adds typed external metadata helpers. |
agentHostSchema.ts |
Defines Agent Host visibility configuration. |
Review details
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 10/10 changed files
- Comments generated: 4
- Review effort level: Balanced
Add a user-controlled external session window, central catalog ownership tracking, and immediate client reconciliation while preserving live and legacy-adoptable sessions. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Keep broadcast state independent from list requests, expire time-window sessions automatically, preserve registry ownership during restore, and cover the discovery lifecycle. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
5a7f968 to
f8fb4e5
Compare
Summary
chat.agentSessions.showExternalwith none, all, last 24 hours, and last 7 days modesValidation
npm run compilenpm run compile-clientscripts\test.bat --run src\vs\platform\agentHost\test\node\agentSessionRegistry.test.ts --run src\vs\platform\agentHost\test\node\agentService.test.ts(274 passing)Reviewer notes
The unreleased version-1
agent-host.dbschema now includesis_external; existing development databases must be recreated. No migration is included by design.Full
npm run hygieneis blocked on Windows by an unrelated path-resolution error that resolvesremote\package.jsonasC:\C:\....