change default to manual - #330554
Draft
Justin Chen (justschen) wants to merge 1 commit into
Draft
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Renames Agent Host’s baseline approval mode from “Default” to “Manual,” including configuration migration and compatibility handling.
Changes:
- Introduces the
manualdefault-configuration value. - Migrates legacy
defaultandautoApprovevalues. - Updates Agent Host labels, documentation, and tests.
Show a summary per file
| File | Description |
|---|---|
src/vs/workbench/contrib/chat/test/common/constants.test.ts |
Tests permission-value mappings. |
src/vs/workbench/contrib/chat/test/browser/agentSessions/agentHostChatInputPicker.test.ts |
Updates picker expectations. |
src/vs/workbench/contrib/chat/common/constants.ts |
Defines and maps manual. |
src/vs/workbench/contrib/chat/browser/chat.shared.contribution.ts |
Updates schema, defaults, copy, and migration. |
src/vs/workbench/contrib/chat/browser/agentSessions/agentHost/agentHostChatInputPicker.ts |
Renames the sandboxed label. |
src/vs/workbench/contrib/chat/browser/agentSessions/agentHost/agentHostChatInputPicker.contribution.ts |
Updates action documentation. |
src/vs/sessions/SESSIONS.md |
Documents revised permission terminology. |
src/vs/sessions/contrib/providers/agentHost/test/browser/localAgentHostSessionsProvider.test.ts |
Updates configuration fixtures. |
src/vs/sessions/contrib/providers/agentHost/test/browser/agentHost/agentHostPermissionPickerDelegate.test.ts |
Updates picker metadata expectations. |
src/vs/sessions/contrib/providers/agentHost/browser/agentHostPermissionPickerDelegate.ts |
Overrides the Agent Host label. |
src/vs/platform/agentHost/test/common/agentHostSchema.test.ts |
Updates schema expectations. |
src/vs/platform/agentHost/common/agentHostSchema.ts |
Renames the protocol-facing picker label. |
Review details
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 12/12 changed files
- Comments generated: 2
- Review effort level: Balanced
| return { ...meta, detail: localize('agentHostPermissionPicker.askWhenNeeded.detail', "Asks when approval settings don't apply") }; | ||
| return { | ||
| ...meta, | ||
| label: localize('agentHostPermissionPicker.manual.label', "Manual permissions"), |
| enum: ['default', 'assisted', 'autoApprove'], | ||
| enumLabels: [ | ||
| localize('agentHost.sessionConfig.autoApprove.default', "Default permissions"), | ||
| localize('agentHost.sessionConfig.autoApprove.default', "Manual permissions"), |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
changes name from
default permissionstomanual permissionsto align with app and cli