Skip to content

sessions: preserve single pane dismissal state - #330603

Merged
Sandeep Somavarapu (sandy081) merged 2 commits into
mainfrom
sandy081/agents/hide-show-hide-editor-action-148c546d
Aug 13, 2026
Merged

sessions: preserve single pane dismissal state#330603
Sandeep Somavarapu (sandy081) merged 2 commits into
mainfrom
sandy081/agents/hide-show-hide-editor-action-148c546d

Conversation

@sandy081

Copy link
Copy Markdown
Member

Follow-up to #330573.

What changed

  • avoid globally hiding the side pane when an editor closes while multiple Existing sessions are visible
  • preserve a user-dismissed Files tab across Existing-to-Existing navigation while continuing to replace Changes in place
  • keep empty-group default restoration and superseded-reconcile generation safety
  • remove the unused PendingAuxiliaryBarRestore enum
  • add focused multi-session close and session-switch dismissal coverage

Validation

  • affected layout suites: 144 passing
  • npm run compile
  • npm run typecheck-client
  • npm run valid-layers-check
  • npm run hygiene
  • git diff --check

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings August 13, 2026 07:49
@sandy081 Sandeep Somavarapu (sandy081) added this to the 1.134.0 milestone Aug 13, 2026
@vs-code-engineering

vs-code-engineering Bot commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

📬 CODENOTIFY

The following users are being notified based on files changed in this PR:

Benjamin Christopher Simmonds (@benibenj)

Matched files:

  • src/vs/sessions/contrib/layout/browser/baseSessionLayoutController.ts
  • src/vs/sessions/contrib/layout/browser/singlePane/singlePaneDockedTabsCoordinator.ts
  • src/vs/sessions/contrib/layout/browser/singlePane/singlePaneExistingSessionStrategy.ts
  • src/vs/sessions/contrib/layout/browser/singlePane/singlePaneVisibilityProfileStore.ts
  • src/vs/sessions/contrib/layout/browser/singlePaneLayoutController.ts
  • src/vs/sessions/contrib/layout/test/browser/desktopSessionLayoutController.test.ts
  • src/vs/sessions/contrib/layout/test/browser/layoutControllerTestUtils.ts
  • src/vs/sessions/contrib/layout/test/browser/singlePaneStrategies.test.ts

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Refines single-pane session lifecycle behavior to preserve side-pane and managed-tab state across session navigation.

Changes:

  • Prevents side-pane dismissal when multiple sessions are visible.
  • Preserves dismissed Files tabs while replacing Changes tabs.
  • Adds focused lifecycle regression tests and removes an unused enum.
Show a summary per file
File Description
singlePaneStrategies.test.ts Tests multi-session editor closure behavior.
desktopSessionLayoutController.test.ts Tests managed-tab restoration and dismissal.
singlePaneVisibilityProfileStore.ts Removes an unused enum.
singlePaneExistingSessionStrategy.ts Avoids global pane hiding with multiple sessions.
singlePaneDockedTabsCoordinator.ts Changes Files-tab reconciliation across session switches.

Review details

💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

  • Files reviewed: 5/5 changed files
  • Comments generated: 1
  • Review effort level: Balanced

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@sandy081
Sandeep Somavarapu (sandy081) merged commit 020477a into main Aug 13, 2026
44 of 45 checks passed
@sandy081
Sandeep Somavarapu (sandy081) deleted the sandy081/agents/hide-show-hide-editor-action-148c546d branch August 13, 2026 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants