fix: include multiline TextView in iOS accessibility dump#294
Open
Ernest94 wants to merge 1 commit into
Open
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
WalkthroughWDA source filtering now accepts 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Member
|
@Ernest94 I only got to this now. I'm sorry. Can you please sign your commits so I can merge? Thank you!! |
Multiline React Native TextInput renders as UITextView (XCUIElementTypeTextView), which was missing from acceptedTypes so it was dropped from the dump and could not be located or filled. Add TextView to the accepted and always-include sets, matching TextField. Fixes mobile-next#293 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
f87ffcc to
613c727
Compare
Author
|
@gmegidish I signed the commit, thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Multiline React Native
TextInputcomponents render on iOS as aUITextView, which WDA reports asXCUIElementTypeTextView. The accessibility-dump filter indevices/wda/source.goonly acceptedTextField(single-lineUITextField), so multiline inputs were dropped from the tree entirely — making them impossible to locate (getByLabel()) or fill.Fixes #293
Fix
Add
TextViewto both theacceptedTypeslist and thealwaysIncludeset infilterSourceElements, mirroring howTextFieldis handled (so it's kept even when it has no label/name yet, e.g. an auto-focused empty field).Tests
Added two tests in
source_test.go:TextViewis included in the dumpTextViewis always includedgo test ./devices/wda/passes.🤖 Generated with Claude Code