Skip to content

fix(server): thread locales through device.apps.launch JSON-RPC handler - #303

Merged
gmegidish merged 1 commit into
mainfrom
fix/apps-launch-locales-jsonrpc
Jul 16, 2026
Merged

fix(server): thread locales through device.apps.launch JSON-RPC handler#303
gmegidish merged 1 commit into
mainfrom
fix/apps-launch-locales-jsonrpc

Conversation

@gmegidish

Copy link
Copy Markdown
Member

The JSON-RPC device.apps.launch handler dropped the locales param: AppsLaunchParams had no Locales field and the commands.AppRequest it built never set one. Launching with a locale over JSON-RPC (the path mobilefleet uses) was a silent no-op — the CLI path was unaffected. Adds the field and threads it through.

@coderabbitai

coderabbitai Bot commented Jul 16, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: eff84acd-dd6b-4b51-ae9d-17d3918a8516

📥 Commits

Reviewing files that changed from the base of the PR and between 9d0f39a and ce072f4.

📒 Files selected for processing (1)
  • server/server.go

Walkthrough

App launch parameters now support an optional locales JSON array. The app launch handler forwards the parsed locale values to commands.AppRequest.Locales when constructing the request.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: threading locales through the device.apps.launch JSON-RPC handler.
Description check ✅ Passed The description accurately describes the locale parameter fix and the JSON-RPC path affected.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/apps-launch-locales-jsonrpc

Comment @coderabbitai help to get the list of available commands.

@gmegidish
gmegidish merged commit 9b99c19 into main Jul 16, 2026
19 checks passed
@gmegidish
gmegidish deleted the fix/apps-launch-locales-jsonrpc branch July 16, 2026 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant