feat(io): add keyboard status and hide commands (android) - #333
Open
gmegidish wants to merge 2 commits into
Open
feat(io): add keyboard status and hide commands (android)#333gmegidish wants to merge 2 commits into
gmegidish wants to merge 2 commits into
Conversation
📝 WalkthroughWalkthroughAdds device-scoped ChangesKeyboard control
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant CLI
participant KeyboardCommands
participant AndroidDevice
participant ADB
CLI->>KeyboardCommands: Execute status or hide with device ID
KeyboardCommands->>AndroidDevice: Resolve keyboard-controllable device
AndroidDevice->>ADB: Query or dismiss keyboard
ADB-->>AndroidDevice: Return command result
AndroidDevice-->>KeyboardCommands: Return visibility or dismissal result
KeyboardCommands-->>CLI: Return JSON response or wrapped error
Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@devices/android_keyboard.go`:
- Around line 20-26: Update the mInputShown parsing loop in status to inspect
whitespace-separated fields rather than requiring the field to start the trimmed
line, then parse its value with strconv.ParseBool and propagate invalid-value
errors. Add a regression test covering mInputShown appearing after the other
fields on the same dumpsys output line.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 4a1a7146-7ea8-4b2d-baf4-049e39cf119e
📒 Files selected for processing (4)
cli/io.gocommands/keyboard.godevices/android_keyboard.godevices/common.go
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mobilecli io keyboard statusandmobilecli io keyboard hidefor Android devices.devices.KeyboardControllableoptional interface — onlyAndroidDeviceimplements it, so iOS (real + simulator) and remote devices return a clear "not supported" error instead of a stub/panic.IsKeyboardVisible()/HideKeyboard()shell out directly viaadb shell dumpsys input_method(mInputShown=) andadb shell input keyevent 4(BACK) — no on-device agent, no app-debuggable requirement.HideKeyboardonly sends BACK when the keyboard is actually visible, so it never fires a stray back-navigation.