fix(server-sse-polling): send mcp-protocol-version 2025-11-25 (the version this scenario tests)#366
Merged
Conversation
…rsion this scenario tests) The scenario has introducedIn: '2025-11-25' and tests SEP-1699 priming events, which were introduced in that version. Sending '2025-03-26' as the client's protocol version makes a correctly-behaving server suppress the priming event (older clients cannot handle empty-data SSE), so the scenario WARNs against a conformant server. Verified against typescript-sdk@v2-2026-07-28: with this fix the scenario goes from 'WARNING: Server did not send priming event' to '3 passed, 0 failed'.
commit: |
pcarleton
approved these changes
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
server-sse-pollingscenario hasintroducedIn: '2025-11-25'and tests SEP-1699 priming events (which require empty-data SSE support, introduced in2025-11-25). But the scenario's raw-fetch probes sendmcp-protocol-version: '2025-03-26'.A server that correctly version-gates priming events (suppressing them for clients whose declared version predates empty-data SSE support) will never emit a priming event for this scenario, so the scenario emits
WARNING: Server did not send priming eventagainst a conformant implementation.How Has This Been Tested?
Verified against
typescript-sdk@v2-2026-07-28(which gates priming onprotocolVersion >= '2025-11-25'): with this fix,server-sse-pollinggoes fromWARNINGto✓ 3 passed, 0 failed.Types of changes