fix: stop emitting a process-wide SIGINT in run-method.test so the CLI suite passes on Windows - #1995
Draft
olaservo wants to merge 1 commit into
Draft
fix: stop emitting a process-wide SIGINT in run-method.test so the CLI suite passes on Windows#1995olaservo wants to merge 1 commit into
olaservo wants to merge 1 commit into
Conversation
…t instead of emitting a process-wide signal Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1941
Test-only.
process.emit("SIGINT")also wokewhen-exit's module-load handler (pulled in viaatomically), whoseprocess.kill(pid, "SIGINT")re-raise is an unconditional TerminateProcess on Windows — killing the vitest worker mid-test. The test now captures the one listenerconsumeMethodOutcomeregisters and invokes it directly, which also strengthens the assertion. Verified: full suite green on Windows (25 files, 304 tests), plus typecheck. Full root-cause in the issue comment.🤖 Generated with Claude Code