fix: settle ink input handlers after frame waits so TUI coverage runs stop flaking on Windows - #1996
Draft
olaservo wants to merge 1 commit into
Draft
fix: settle ink input handlers after frame waits so TUI coverage runs stop flaking on Windows#1996olaservo wants to merge 1 commit into
olaservo wants to merge 1 commit into
Conversation
…I App tests Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1942
Test-only. In ink 6 a visible frame doesn't imply armed
useInputhandlers (they re-subscribe in the passive-effect flush), so a keypress right after a frame wait could be silently swallowed — v8 instrumentation widens the window, hence the coverage-only flake.waitUntilnow awaits onesetImmediateturn after its predicate passes; check-queue FIFO guarantees the effect flush runs first. Verified: race made deterministic via a 1ms-poll amplifier (3/3 failing before, 3/3 green after) plus 3 consecutive full greentest:coverageruns. Full root-cause in the issue comment.🤖 Generated with Claude Code