Conversation
Malformed protected resource metadata returned with HTTP 200 now fails the auth flow with the schema error instead of falling back to legacy discovery. Signed-off-by: 1fanwang <1fannnw@gmail.com>
🦋 Changeset detectedLatest commit: 1c676b3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@modelcontextprotocol/client
@modelcontextprotocol/codemod
@modelcontextprotocol/core
@modelcontextprotocol/server
@modelcontextprotocol/server-legacy
@modelcontextprotocol/express
@modelcontextprotocol/fastify
@modelcontextprotocol/hono
@modelcontextprotocol/node
commit: |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Malformed protected-resource metadata returned with HTTP 200 used to disappear inside auth discovery. Users then saw a later Dynamic Client Registration failure instead of the invalid metadata.
AI disclosure: GitHub Copilot CLI helped implement and validate this bug fix under human direction.
Motivation and Context
This keeps the RFC 9728 fallback for missing metadata. A 200 response is now authoritative: invalid metadata stops auth with the schema error.
Fixes #2866
How Has This Been Tested?
Before: a local Node server returned malformed metadata with HTTP 200 through auth. The SDK reported Dynamic Client Registration instead of validation.
After: the same path raises Invalid OAuth protected resource metadata. Client auth tests pass.
Raw logs
Breaking Changes
None.
Types of changes
Checklist
Additional context
Client and repo typecheck, lint, and build completed locally.