[v1.x] fix(stdio): skip non-JSON lines in ReadBuffer (backport of #1762) - #2872
Open
constantbourgois wants to merge 2 commits into
Open
constantbourgois wants to merge 2 commits into
constantbourgois wants to merge 2 commits into
Conversation
🦋 Changeset detectedLatest commit: cc28f01 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
constantbourgois
marked this pull request as draft
September 25, 2026 09:24
…-JSON lines are skipped Claude-Session: https://claude.ai/code/session_01AXYSLfPNRScfVikFh2gpdA
constantbourgois
marked this pull request as ready for review
September 25, 2026 09:31
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #780 on v1.x.
Cause:
ReadBuffer.readMessage()passes every stdout line toJSON.parse. When a stdio server prints a non-JSON line (e.g.Shutting down server...on close), aSyntaxErrorsurfaces viaonerror.Fix: backport of #1762 from main: loop over buffered lines and skip those that throw
SyntaxError. Valid JSON that fails schema validation still throws.Repro (1.30.1): a stdio server that writes
Shutting down server...\nto stdout when stdin ends; connect aClientwithStdioClientTransport, thenclient.close()→onerror: Unexpected token 'S', "Shutting d"... is not valid JSON. With this patch: no error.Tests: ported the
non-JSON line filteringsuite from main (8 tests; 5 fail without the fix). Full suite + lint pass.