chore: remove CODEOWNERS patterns that match nothing on main - #2884
Conversation
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012VRbFCp41otcScXE1YY3es
|
@modelcontextprotocol/client
@modelcontextprotocol/codemod
@modelcontextprotocol/core
@modelcontextprotocol/server
@modelcontextprotocol/server-legacy
@modelcontextprotocol/express
@modelcontextprotocol/fastify
@modelcontextprotocol/hono
@modelcontextprotocol/node
commit: |
There was a problem hiding this comment.
LGTM — straightforward CODEOWNERS cleanup that is a functional no-op on main.
What was reviewed:
- Confirmed
git ls-fileshas no path under a rootsrc/, so all five removed patterns matched nothing and no file changes owner as a result. - Checked the trailing-newline concern: the base file was the one missing it; the new file ends with a newline.
- Noted the PR explicitly leaves remapping auth ownership to
packages/*paths as a separate decision (#2604), so nothing is silently dropped that currently applies.
Extended reasoning...
The diff touches only .github/CODEOWNERS, deleting the five /src/... patterns assigned to the auth team and leaving the catch-all default owner line. It touches no code and no runtime auth surface; the only governance effect is removing stale, non-matching ownership entries, which the PR description acknowledges rather than remapping. Verified in the checkout that no tracked file lives under a root src/, so effective ownership on main is unchanged after merge. The change is tiny, mechanical, and its intent is clear, which decided approve.
Requested by Felix Weinberger · Slack thread
Summary
Removes the auth block from
.github/CODEOWNERS: the five/src/...patterns assigned to@modelcontextprotocol/typescript-sdk-auth.Since the monorepo move there is no root-level
src/onmain(git ls-files | grep -c '^src/'is 0), so none of these patterns match any file and they do nothing. This change makes the file reflect what actually happens: everything falls to the*default owner.This PR does not remap the patterns to the new
packages/*paths; whether the auth team should own specific paths in the monorepo layout is a separate decision.v1.xis untouched, since the patterns are valid there.Fixes #2604
Changes
.github/CODEOWNERS: remove the# Auth team owns all auth-related codecomment and the five patterns under it. Header comment and*default line are unchanged.Testing
mainthatgit ls-filescontains no path under a rootsrc/and no file matched by any of the removed patterns.🤖 Generated with Claude Code
https://claude.ai/code/session_012VRbFCp41otcScXE1YY3es
Generated by Claude Code