Skip to content

chore: remove CODEOWNERS patterns that match nothing on main - #2884

Merged
felixweinberger merged 2 commits into
mainfrom
chore/codeowners-remove-stale-patterns
Sep 28, 2026
Merged

felixweinberger merged 2 commits into
mainfrom
chore/codeowners-remove-stale-patterns

Conversation

@claude

@claude claude Bot commented Sep 28, 2026

Copy link
Copy Markdown
Contributor

Requested by Felix Weinberger · Slack thread

Summary

Removes the auth block from .github/CODEOWNERS: the five /src/... patterns assigned to @modelcontextprotocol/typescript-sdk-auth.

Since the monorepo move there is no root-level src/ on main (git ls-files | grep -c '^src/' is 0), so none of these patterns match any file and they do nothing. This change makes the file reflect what actually happens: everything falls to the * default owner.

This PR does not remap the patterns to the new packages/* paths; whether the auth team should own specific paths in the monorepo layout is a separate decision.

v1.x is untouched, since the patterns are valid there.

Fixes #2604

Changes

  • .github/CODEOWNERS: remove the # Auth team owns all auth-related code comment and the five patterns under it. Header comment and * default line are unchanged.

Testing

  • Verified on main that git ls-files contains no path under a root src/ and no file matched by any of the removed patterns.
  • Pre-push hooks (build, typecheck, lint) pass.

🤖 Generated with Claude Code

https://claude.ai/code/session_012VRbFCp41otcScXE1YY3es


Generated by Claude Code

@claude
claude Bot requested a review from a team as a code owner September 28, 2026 14:09
@changeset-bot

changeset-bot Bot commented Sep 28, 2026 •

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: e8e0dd5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@pkg-pr-new

pkg-pr-new Bot commented Sep 28, 2026 •

Copy link
Copy Markdown

Open in StackBlitz

@modelcontextprotocol/client

npm i https://pkg.pr.new/@modelcontextprotocol/client@2884

@modelcontextprotocol/codemod

npm i https://pkg.pr.new/@modelcontextprotocol/codemod@2884

@modelcontextprotocol/core

npm i https://pkg.pr.new/@modelcontextprotocol/core@2884

@modelcontextprotocol/server

npm i https://pkg.pr.new/@modelcontextprotocol/server@2884

@modelcontextprotocol/server-legacy

npm i https://pkg.pr.new/@modelcontextprotocol/server-legacy@2884

@modelcontextprotocol/express

npm i https://pkg.pr.new/@modelcontextprotocol/express@2884

@modelcontextprotocol/fastify

npm i https://pkg.pr.new/@modelcontextprotocol/fastify@2884

@modelcontextprotocol/hono

npm i https://pkg.pr.new/@modelcontextprotocol/hono@2884

@modelcontextprotocol/node

npm i https://pkg.pr.new/@modelcontextprotocol/node@2884

commit: e8e0dd5

@claude claude Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM — straightforward CODEOWNERS cleanup that is a functional no-op on main.

What was reviewed:

  • Confirmed git ls-files has no path under a root src/, so all five removed patterns matched nothing and no file changes owner as a result.
  • Checked the trailing-newline concern: the base file was the one missing it; the new file ends with a newline.
  • Noted the PR explicitly leaves remapping auth ownership to packages/* paths as a separate decision (#2604), so nothing is silently dropped that currently applies.
Extended reasoning...

The diff touches only .github/CODEOWNERS, deleting the five /src/... patterns assigned to the auth team and leaving the catch-all default owner line. It touches no code and no runtime auth surface; the only governance effect is removing stale, non-matching ownership entries, which the PR description acknowledges rather than remapping. Verified in the checkout that no tracked file lives under a root src/, so effective ownership on main is unchanged after merge. The change is tiny, mechanical, and its intent is clear, which decided approve.

@felixweinberger
felixweinberger merged commit d992df7 into main Sep 28, 2026
19 checks passed
@felixweinberger
felixweinberger deleted the chore/codeowners-remove-stale-patterns branch September 28, 2026 14:32
@claude claude Bot mentioned this pull request Sep 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CODEOWNERS auth paths do not resolve on main, so the auth team is never auto-requested

2 participants