refactor(review): rename byte-size, digest, and conformance-registry modules for the roles they play

[benvinegar]

Second cleanup PR from the post-merge Opus review (follows #736): naming fixes only, no logic changes.

Renames

• core/review/noteBounds.ts → noteSize.ts, reviewNoteWithinBounds → reviewNoteWithinSizeLimit. The module measures serialized bytes, but CLAUDE.md reserves "bounds" for a concrete visible extent and the codebase honors that spatially everywhere (rowBounds, hunkBounds, selectedNoteBounds, VerticalBounds) — this was the one vocabulary break, sitting greppably next to the spatial note-card concept in the same feature area. MAX_REVIEW_NOTE_BYTES and reviewNoteByteLength were already unambiguous and keep their names. The conformance fixture file follows (ReviewNoteSizeFixture, REVIEW_NOTE_SIZE_FIXTURES, fixture field withinSizeLimit).
• app/review/digest.ts → src/lib/reviewDigest.ts. Its header claimed "the producer's hashing implementation", but the daemon imports it too — the location made the broker carry an import edge into the app tier for three lines of Node hashing. src/lib/ is the existing home for tier-neutral primitives; the header now says what it is: the Node implementation of the shared ReviewDigestFn, injected by whichever tier owns bytes.
• MAX_REVIEW_RESOURCE_CACHE_BYTES → MAX_REVIEW_PRODUCER_RESOURCE_BYTES. It and MAX_REVIEW_DAEMON_CACHE_BYTES are identical 64 MB budgets in two tiers; only the daemon's named its tier, so a contributor tuning "the cache" had a coin-flip.
• REVIEW_CONFORMANCE_CONSUMERS/FIXTURES → REVIEW_GEOMETRY_CONSUMERS/FIXTURES (file fixtures.ts → geometryFixtures.ts), with the geometry-specific types following (ReviewGeometryConsumer etc.). Four peer registries exist — geometry, navigation, ordering, wire — and three were named for what they cover while the first wore the harness's generic name, so a future consumer would join the wrong registry. Genuinely shared harness vocabulary (ConformanceGap, ConformanceLineAddress, ConformanceSelection) keeps its prefix.
• app/review/publication.ts header gains one cross-reference: the addressing/ordering vocabulary lives in core/review/generationOrder.ts (matching its existing pointer at core/review/document.ts).

Doc references in docs/browser-review-seam-audit.md were updated only where they'd now be wrong as instructions; historical narrative is untouched. No gate path-lists referenced the renamed files.

Gates

bun run typecheck clean; conformance + core + app + session suites 725 pass / 0 fail after rebasing onto main (post-#736 squash); bun run lint 0/0; bun run format clean. Full bun test on the pre-rebase branch matched its baseline (one PTY flake, passes in isolation; the two pre-existing @axe-core/playwright website errors). Empty changeset (maintenance).

---

Generated by Claude Code

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
hunk-web	Ignored	Preview	Aug 14, 2026 7:46pm

[greptile-apps]

Greptile Summary

This PR consistently renames review modules, limits, fixtures, registries, and related documentation to clarify their roles without changing behavior.

• Renames note byte-size APIs and their conformance fixtures.
• Moves the shared Node review-digest implementation from the app tier into src/lib.
• Clarifies producer resource-budget and geometry-registry names.
• Updates all affected imports, tests, comments, and documentation references.

Confidence Score: 5/5

The PR appears safe to merge because the renames and module relocation are complete and preserve existing behavior.

Repository-wide references, registry memberships, configuration coverage, and the relocated digest implementation remain consistent, with no concrete changed-code failure identified.

Important Files Changed

Filename	Overview
src/core/review/noteSize.ts	Renames the note-size module and predicate without changing byte measurement or limit behavior.
src/lib/reviewDigest.ts	Relocates the unchanged Node SHA-256 implementation to a tier-neutral internal utility path used by Node-side callers.
src/app/review/resourceStore.ts	Renames the producer cache-budget constant and updates its default use without changing the 64 MB value.
src/session/broker/state.ts	Updates the broker's digest import to the relocated implementation with no behavioral change.
src/session/reviewProtocol.ts	Updates note-size terminology while preserving the existing transportability check.
test/review-conformance/geometryFixtures.ts	Renames the geometry fixture module and types while preserving all fixture data and registry membership.
test/review-conformance/conformance.test.ts	Updates conformance imports and registry names consistently across geometry and note-size checks.

_{Reviews (1): Last reviewed commit: "chore: add an empty changeset for the re..." | Re-trigger Greptile}