Skip to content

test(markers): fix the scikit-learn requires_pkg marker - #2821

Merged
wpbonelli merged 1 commit into
modflowpy:developfrom
jdhughes-dev:fix-sklearn-marker
Aug 23, 2026
Merged

test(markers): fix the scikit-learn requires_pkg marker#2821
wpbonelli merged 1 commit into
modflowpy:developfrom
jdhughes-dev:fix-sklearn-marker

Conversation

@jdhughes-dev

Copy link
Copy Markdown
Contributor

requires_pkg() resolves a distribution name and imports the matching module, so
scikit-learn matches neither name on its own — the distribution is scikit-learn and the
module is sklearn. test_save_load_node_mapping_structured was skipped everywhere as a
result, including the nightly optional dependency build, and had never run.

  • map the distribution to its module with name_map, as requires_pkg() documents for this case
  • the test passes once it runs

@codecov

codecov Bot commented Aug 23, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.4%. Comparing base (556c088) to head (e097b31).
⚠️ Report is 209 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2821      +/-   ##
===========================================
+ Coverage     55.5%    73.4%   +17.8%     
===========================================
  Files          644      659      +15     
  Lines       124135   132188    +8053     
===========================================
+ Hits         68947    97044   +28097     
+ Misses       55188    35144   -20044     

see 585 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jdhughes-dev
jdhughes-dev removed the request for review from jlarsen-usgs August 23, 2026 05:58
@jdhughes-dev jdhughes-dev changed the title test(model_splitter): fix the scikit-learn requires_pkg marker test(markers): fix the scikit-learn requires_pkg marker Aug 23, 2026
requires_pkg() resolves a distribution name and imports the matching module, and
scikit-learn matches neither name on its own: the distribution is scikit-learn and
the module is sklearn. test_save_load_node_mapping_structured was therefore skipped
everywhere, including the nightly optional dependency build, and had never run. Map
the distribution to its module so the test runs.
@wpbonelli
wpbonelli merged commit 7a6af59 into modflowpy:develop Aug 23, 2026
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants