ci(commit): install h5py for the test job - #2822
Open
jdhughes-dev wants to merge 1 commit into
Open
Conversation
The test job runs in the MODFLOW 6 pixi environment and installs FloPy with --no-deps, so none of the optional extras are present and every test guarded by requires_pkg() for them is skipped. h5py gates the four node mapping save and load tests, which have never run on a pull request. pymetis and scikit-learn gate the remaining skipped tests and are left for a follow-up.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #2822 +/- ##
===========================================
+ Coverage 55.5% 73.5% +17.9%
===========================================
Files 644 659 +15
Lines 124135 132188 +8053
===========================================
+ Hits 68947 97177 +28230
+ Misses 55188 35011 -20177 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Testjob runs in the MODFLOW 6 pixi environment and installs FloPy with--no-deps,then adds only
coverage pytest-cov netcdf4. None of theoptionalextras are present, soevery test guarded by
requires_pkg()for them is skipped on a pull request.test_save_load_node_mapping_vertex,test_save_load_node_mapping_unstructured,and
test_save_node_mapping_with_boundnames, none of which have run on a pull request