ci(optional): stop uv run from reinstalling the removed dependencies - #2823
Draft
jdhughes-dev wants to merge 1 commit into
Draft
ci(optional): stop uv run from reinstalling the removed dependencies#2823jdhughes-dev wants to merge 1 commit into
jdhughes-dev wants to merge 1 commit into
Conversation
uv run re-syncs the project before it runs the command, which undoes both the --only-group test install and the random uninstall that precede it. Both matrix variants therefore run the full test suite with every optional dependency present, and the workflow has not been testing the absence of any of them. In the 22 Aug run the no optional dependencies job reported all 21 optional packages installed and passed tests that require pymetis. Run pytest with --no-sync so the environment the steps built is the one used, and add a workflow_dispatch trigger so the workflow can be run on demand.
jdhughes-dev
requested review from
jlarsen-usgs and
wpbonelli
and removed request for
jlarsen-usgs
August 23, 2026 05:46
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #2823 +/- ##
===========================================
+ Coverage 55.5% 73.3% +17.8%
===========================================
Files 644 659 +15
Lines 124135 132188 +8053
===========================================
+ Hits 68947 97013 +28066
+ Misses 55188 35175 -20013 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
uv runre-syncs the project before running the command, which undoes both theuv sync --only-group testinstall and the randomuv pip uninstallthat precede it. Bothmatrix variants therefore run the full suite with every optional dependency present, so the
workflow has not been testing the absence of any of them.
Evidence from the 22 Aug run (32562777097):
the
no optional dependenciesjob logsoptional packages: affine-3.0.0, ..., h5py-3.16.0, ..., pymetis-2025.2.2, ...and passestest_model_splitter.py::test_multi_model, which requires pymetis.--no-syncso the environment the preceding steps built is the one usedworkflow_dispatchtrigger so the workflow can be run on demandOpened as a draft: once the constraint is actually enforced this may surface tests that do not
degrade gracefully, which is the point of the workflow, but I cannot exercise it from a branch —
workflow_dispatchonly appears once the trigger is on the default branch.