test(model_splitter): cover the horizontal flow barrier package - #2824
Open
jdhughes-dev wants to merge 2 commits into
Open
test(model_splitter): cover the horizontal flow barrier package#2824jdhughes-dev wants to merge 2 commits into
jdhughes-dev wants to merge 2 commits into
Conversation
The HFB package had no splitting test. Split a model with barriers on either side of the split column and check that each model keeps its own barriers and that the heads reconstruct to the original model, then check that splitting a model along a barrier is an error.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #2824 +/- ##
===========================================
+ Coverage 55.5% 73.4% +17.9%
===========================================
Files 644 659 +15
Lines 124135 132188 +8053
===========================================
+ Hits 68947 97096 +28149
+ Misses 55188 35092 -20096 🚀 New features to boost your workflow:
|
Cover the corner four cells share, where two barriers between east west neighbors and two between north south neighbors meet, and check that splitting on either the row or the column the junction straddles is an error. Add barriers on vertical connections, which the splitter never divides because both cells of one are in the same stack.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The HFB package had no splitting test, so neither the cellid remapping nor the restriction
that a barrier cannot be split was covered.
between north south neighbors meet in a plus, and check that splitting on either the row or
the column that junction straddles is an error
of one are in the same stack
reconstruct to the original model