refactor(labrinth): combine logic for external notification endpoints#6578
Open
Sychic wants to merge 3 commits into
Open
refactor(labrinth): combine logic for external notification endpoints#6578Sychic wants to merge 3 commits into
Sychic wants to merge 3 commits into
Conversation
Member
Pull request changelogAppAddedChangedDeprecatedRemovedFixedSecurityWebsiteAddedChangedDeprecatedRemovedFixedSecurityHostingAddedChangedDeprecatedRemovedFixedSecurity |
fetchfern
requested changes
Jul 1, 2026
| let status = if failed.is_empty() { | ||
| StatusCode::ACCEPTED | ||
| } else { | ||
| StatusCode::MULTI_STATUS |
Member
There was a problem hiding this comment.
207 is more of a WebDAV-only status code; would change the endpoint to turn a map of user IDs -> email send status (no email associated with account | failed to send (likely invalid email) | internal error)
also introduce new notification that doesn't send an email
Sychic
force-pushed
the
sychic/notification-refactor
branch
from
e563e9e to
7f1a3f7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
also introduce method to not send an email