fix(grid): relation-поля в гриде «Товары категории» (#328)#330
Open
Ibochkarev wants to merge 1 commit into
Open
fix(grid): relation-поля в гриде «Товары категории» (#328)#330Ibochkarev wants to merge 1 commit into
Ibochkarev wants to merge 1 commit into
Conversation
Category products list now JOINs related tables for relation-type grid columns (e.g. vendor address via vendor_id on msProductData). Adds GridRelationColumnResolver, SQL identifier validation, and reserved field name checks. Closes modx-pro#328.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Описание
Relation-поля (тип
relation) в утилите «Поля таблиц» для грида «Товары категории» сохранялись в конфиге, но при загрузке списка не резолвились: вместо адреса/телефона производителя показывался сыройvendor_id,idили название категории.Добавлен JOIN/SELECT для relation-колонок в
CategoryProductsListServiceпо паттерну orders. Для FK наmsProductData(напримерvendor_id) JOIN идёт через aliasData, а неmsProduct. РасширенresolveModelClass()для имён таблицms3_vendors/ с префиксом. Добавлены валидация SQL-идентификаторов, проверка коллизий имён с builtin-колонками и статический тест.Тип изменений
Связанные Issues
Closes #328
Как это было протестировано?
Конфигурация тестирования:
php -l,php tests/RelationColumnSpecTest.php)Проверки:
php -lна всех изменённых PHP-файлахphp tests/RelationColumnSpecTest.php— join condition, reserved names, SQL identifier guardРучной сценарий (после деплоя):
vendor_address(msVendor/ms3_vendors, FKvendor_id, displayaddress)Скриншоты (если применимо)
Чеклист
Дополнительные заметки
GridRelationColumnResolver,RelationColumnSpec,GridColumnRules,ProductDataForeignKeysvendor_address, неvendor_id(builtin-колонка)aggregationдля relation в category-products явно запрещён при сохранении конфигаproduct[column.name]