Conversation
Regenerated from the stream protos, with the submodule pointed at the branch that carries them.
`AddStreamMessagesCommandAttributes` reaches a `Payload` through both the message body and its metadata map, so two more are visitable.
moedash
force-pushed
the
moe/AI-198-stream-commands
branch
from
September 16, 2026 22:36
3f7be18 to
5ea9c67
Compare
3 tasks
The submodule now tracks the recorded sha rather than the feature branch head, so a later push to that branch cannot change what make proto emits.
The stream record now carries its kind and producer identity on the wire, and the command, event and range names follow the record vocabulary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
This PR adds the generated Go for the stream protos, plus corrected payload-walker counts for the two
Payloadfields reachable throughAppendStreamRecordsCommandAttributes(a record'sbodyand itsmetadatavalues). The proto submodule points at a fixed commit of the api branch rather than tracking the branch, so a later push there cannot change whatmake protoemits. The submodule URL stays on the fork until the api change lands upstream.Fixes AI-198
Why?
The server pins
go.temporal.io/apiat this head. Nothing here is hand-written except the walker counts; the rest is generated output.How did you test it?
Link to a test plan if any -
make check test(regeneration diff plus the suite) is green in CI. The server's functional tests run against this module downstream.