PYTHON-6002 Increase wait_until timeout for test_heartbeat_awaited_flag on PyPy - #2987
Open
blink1073 wants to merge 1 commit into
Open
PYTHON-6002 Increase wait_until timeout for test_heartbeat_awaited_flag on PyPy#2987blink1073 wants to merge 1 commit into
blink1073 wants to merge 1 commit into
Conversation
…ag on PyPy PyPy's JIT warm-up can delay the heartbeat monitor thread past the default 10s wait_until timeout on slow/throttled CI runners, causing near-consistent failures on the pypy-3.11-ubuntu-latest GitHub Actions job. Bump the timeout to 30s specifically for PyPy; other interpreters are unaffected.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Contributor
There was a problem hiding this comment.
Pull request overview
Reduces PyPy-specific flakiness in the streaming protocol heartbeat test by increasing the wait_until/async_wait_until timeout only when running under PyPy, keeping existing behavior unchanged for other interpreters.
Changes:
- Add a PyPy-conditional timeout (
30son PyPy,10sotherwise) for waiting on the failed heartbeat event. - Apply the change to the async test source and its regenerated synchronous mirror.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| test/asynchronous/test_streaming_protocol.py | Uses a longer async_wait_until(..., timeout=...) on PyPy to avoid CI JIT warm-up delays. |
| test/test_streaming_protocol.py | Sync mirror regeneration of the same PyPy-conditional timeout for wait_until. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PYTHON-6002
Changes in this PR
test_heartbeat_awaited_flagwas failing near-consistently on thepypy-3.11-ubuntu-latestGitHub Actions job (AssertionError: Didn't ever published failed event), and occasionally on evergreen hosts running PyPy. PyPy's JIT warm-up can delay the heartbeat monitor thread past the test's 10swait_untiltimeout on slow CI runners."PyPy" in sys.version); other interpreters keep 10s.just synchro.Test Plan
mongod— always passed, confirming the race isn't reproducible on demand (it's CI-resource dependent), so this is a timeout fix rather than a logic fix.pytest test/asynchronous/test_streaming_protocol.py test/test_streaming_protocol.pyunder both PyPy 3.11 and CPython — all pass.just lintandjust typingpass.Checklist
Checklist for Author
Checklist for Reviewer