Skip to content

fix(custom-text): update live progress after text changes (@straussg979) - #8401

Open
straussg979 wants to merge 1 commit into
monkeytypegame:masterfrom
straussg979:fix-custom-text-live-progress
Open

fix(custom-text): update live progress after text changes (@straussg979)#8401
straussg979 wants to merge 1 commit into
monkeytypegame:masterfrom
straussg979:fix-custom-text-live-progress

Conversation

@straussg979

Copy link
Copy Markdown

Description

  • When changing custom text from 'x' words to 'y' words (where x and y are a number of words), the progress would still show 0/x until you start typing
  • The custom-text settings came from non-reactive local storage, so the displayed total didn't change.
  • I mirrored those settings in a Solid signal, and added a regression test for immediate updates.

Checks

  • Adding quotes?
    • Make sure to follow the quotes documentation
    • Make sure to include translations for the quotes in the description (or another comment) so we can verify their content.
  • Adding a language?
    • Make sure to follow the languages documentation
    • Add language to packages/schemas/src/languages.ts
    • Add language to exactly one group in frontend/src/ts/constants/languages.ts
    • Add language json file to frontend/static/languages
  • Adding a theme?
    • Make sure to follow the themes documentation
    • Add theme to packages/schemas/src/themes.ts
    • Add theme to frontend/src/ts/constants/themes.ts
    • (optional) Add theme css file to frontend/static/themes
    • Add some screenshots of the theme, especially with different test settings (colorful, flip colors) to your pull request
  • Adding a layout?
    • Make sure to follow the layouts documentation
    • Add layout to packages/schemas/src/layouts.ts
    • Add layout json file to frontend/static/layouts
  • Adding a font?
    • Make sure to follow the fonts documentation
    • Add font file to frontend/static/webfonts
    • Add font to packages/schemas/src/fonts.ts
    • Add font to frontend/src/ts/constants/fonts.ts
  • Check if any open issues are related to this PR; if so, be sure to tag them below.
  • Make sure the PR title follows the Conventional Commits standard. (https://www.conventionalcommits.org for more info)
  • Make sure to include your GitHub username prefixed with @ inside parentheses at the end of the PR title.

Closes #8334

@monkeytypegeorge monkeytypegeorge added the frontend User interface or web stuff label Sep 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

frontend User interface or web stuff

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Live progress doesn't update after custom text change

2 participants