Skip to content

fix aws sigv4 signing - #286

Closed
lbenedix wants to merge 5 commits into
mountain-loop:mainfrom
lbenedix:main
Closed

fix aws sigv4 signing#286
lbenedix wants to merge 5 commits into
mountain-loop:mainfrom
lbenedix:main

Conversation

@lbenedix

Copy link
Copy Markdown

No description provided.

@gschier gschier left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch! Just a few comments.

Comment thread plugins/auth-aws/src/index.ts Outdated
Comment thread plugins/auth-aws/src/index.ts Outdated
Comment thread plugins/auth-aws/src/index.ts Outdated
Comment thread plugins/auth-aws/src/index.ts Outdated
@lbenedix
lbenedix requested a review from gschier October 31, 2025 07:45
@gschier

gschier commented Aug 14, 2026

Copy link
Copy Markdown
Member

Thanks for this, and apologies for the very long silence. A heads-up on where things landed: the signing fix itself shipped separately via #430 (request bodies are now included in the signature).

What's left here is the profile-based credential loading, which is a good idea, but as written the profileName arg is read as values.profile so it wouldn't take effect, and the @aws-sdk dependency is fairly heavy for the plugin. Closing this PR for now, but the feature is tracked and welcome as a fresh PR against current main if you're still interested.

@gschier gschier closed this Aug 14, 2026
@gschier

gschier commented Aug 14, 2026

Copy link
Copy Markdown
Member

The profile-credentials feature is now tracked here if you'd like to vote to follow: https://yaak.app/feedback/posts/load-aws-credentials-from-a-profile-in-the-aws-sigv4-auth-plugin-2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants