Add submenuTrigger option for dropdown items - #548
Merged
Conversation
Adds an opt-in "button" submenu trigger, where the row stays selectable and a dedicated ellipsis button on the right opens the submenu. Also makes keepOpenOnSelect on a submenu item close only that submenu, keeping the parent menu open.
Greptile SummaryAdds configurable row- or button-triggered dropdown submenus while preserving selectable parent rows.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains.
|
| Filename | Overview |
|---|---|
| apps/yaak-client/components/core/Dropdown.tsx | Implements button-triggered submenu rendering, keyboard behavior, selection handling, and the corrected hover-dismissal condition. |
Reviews (2): Last reviewed commit: "Don't dismiss a submenu when hovering th..." | Re-trigger Greptile
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
submenuTrigger: "row" | "button"to dropdown items."row"(default) is existing behavior, so nothing changes for current menus"button"keeps the row selectable viaonSelectand renders an ellipsis button on the right that opens the submenu on click (or ArrowRight)Also makes
keepOpenOnSelecton a submenu item close only that submenu instead of the whole menu, since its items usually no longer describe the row after the action runs.Needed by #338, which uses it for per-item pin/remove actions in the filter history menu.