Skip to content

chore(chromium): update base to 149.0.7827.201#25

Merged
moonrailgun merged 2 commits into
mainfrom
moonrailgun/dump-to-149
Jul 22, 2026
Merged

chore(chromium): update base to 149.0.7827.201#25
moonrailgun merged 2 commits into
mainfrom
moonrailgun/dump-to-149

Conversation

@moonrailgun

@moonrailgun moonrailgun commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Background

Update Dao Browser's Chromium base from 148.0.7778.217 to 149.0.7827.201 and adjust Dao-owned integration code for upstream API and patch drift.

Changes

  • Bump dao.json and related documentation to Chromium 149.0.7827.201.
  • Refresh Chromium patch files for the new upstream source layout and added patch coverage.
  • Migrate Dao browser/window lookups from BrowserList and browser_finder APIs to BrowserWindowInterface and browser collections where required by Chromium 149.
  • Update Dream and Agent integration, including weekly dream report WebUI handlers, external Agent sidebar prefill/session hooks, and stricter report ID validation.
  • Adjust tests and build metadata for Chromium 149 compatibility, including import/release tests, browser tests, WebUI tests, and eslint BUILD.gn typing support.

Testing

Patch contains updates to import/release unit tests, Dao browser tests, Dream browser tests, MV2 browser tests, renderer context menu browser tests, and Agent WebUI tests. No test run evidence was provided.

Summary by CodeRabbit

  • New Features

    • Added weekly Dream reporting in the agent UI (browse sources, open items, and mark reports as viewed).
    • Added QR-code decoding from image context menus.
    • Added Agent sidebar external actions to prefill prompts and reopen existing sessions.
    • Added Dao settings for Little Dao, enhanced command bar suggestions, Ask AI, and enhanced Picture-in-Picture (including preview).
  • Improvements

    • Updated related UI/deep links to use dao:// where applicable.
    • Improved macOS external-link handling to open in Little Dao.
    • Enhanced PiP sizing/placement persistence and removed an auto overlay.
    • Updated Chromium baseline to 149.0.7827.201.

@coderabbitai

coderabbitai Bot commented Jul 21, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@moonrailgun, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 46 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: f720c248-e230-4d71-9791-3f0064c76713

📥 Commits

Reviewing files that changed from the base of the PR and between 4f69e98 and adef776.

📒 Files selected for processing (63)
  • dao.json
  • docs/features.md
  • docs/worktree-engine-cache.md
  • scripts/commands/__tests__/import.test.ts
  • scripts/commands/__tests__/release.test.ts
  • src/dao/browser/agent/dao_agent_proactive_engine.cc
  • src/dao/browser/agent/dao_agent_proactive_engine.h
  • src/dao/browser/agent/dao_dream_browsertest.cc
  • src/dao/browser/agent/dao_dream_service.cc
  • src/dao/browser/agent/dao_dream_service.h
  • src/dao/browser/agent/dao_weekly_dream_material_collector.cc
  • src/dao/browser/extensions/legacy_mv2/dao_mv2_browsertest.cc
  • src/dao/browser/strings/dao_strings.grd
  • src/dao/browser/strings/translations/dao_strings_zh-CN.xtb
  • src/dao/browser/ui/views/dao_agent_sidebar_view.cc
  • src/dao/browser/ui/views/dao_agent_sidebar_view.h
  • src/dao/browser/ui/views/dao_browser_browsertest.cc
  • src/dao/browser/ui/views/dao_command_bar_view.cc
  • src/dao/browser/ui/views/dao_control_center_extensions_section.cc
  • src/dao/browser/ui/views/dao_control_center_utility_section.cc
  • src/dao/browser/ui/views/dao_cross_window_drag.cc
  • src/dao/browser/ui/views/dao_pinned_extensions_container.cc
  • src/dao/browser/ui/views/little_dao/dao_little_dao_controller.cc
  • src/dao/browser/ui/views/little_dao/dao_mini_dao_site_center_popup.cc
  • src/dao/browser/ui/views/sidebar/dao_sidebar_view.cc
  • src/dao/browser/ui/views/split/dao_split_view.cc
  • src/dao/browser/ui/webui/dao_agent_ui.cc
  • src/dao/browser/ui/webui/dao_agent_ui.h
  • src/dao/browser/ui/webui/dao_sidebar_ui.cc
  • src/dao/browser/ui/webui/resources/agent/__tests__/dao_agent_app.test.ts
  • src/dao/browser/ui/webui/resources/agent/__tests__/dao_chat_view.test.ts
  • src/dao/browser/ui/webui/resources/agent/dao_agent_app.ts
  • src/dao/browser/ui/webui/resources/agent/dao_chat_view.ts
  • src/dao/browser/updater/dao_updater_service.cc
  • src/patches/chrome/app/generated_resources.grd.patch
  • src/patches/chrome/app/settings_strings.grdp.patch
  • src/patches/chrome/app/settings_strings_dao.grdp.patch
  • src/patches/chrome/browser/about_flags.cc.patch
  • src/patches/chrome/browser/app_controller_mac.mm.patch
  • src/patches/chrome/browser/app_controller_mac_little_dao_external.mm.patch
  • src/patches/chrome/browser/chrome_browser_main_mac.mm.patch
  • src/patches/chrome/browser/chrome_content_browser_client_force_dark_mode.cc.patch
  • src/patches/chrome/browser/picture_in_picture/picture_in_picture_window_manager.cc.patch
  • src/patches/chrome/browser/renderer_context_menu/render_view_context_menu.cc.patch
  • src/patches/chrome/browser/renderer_context_menu/render_view_context_menu_browsertest.cc.patch
  • src/patches/chrome/browser/ui/BUILD.gn.patch
  • src/patches/chrome/browser/ui/browser_live_tab_context.cc.patch
  • src/patches/chrome/browser/ui/startup/infobar_utils.cc.patch
  • src/patches/chrome/browser/ui/views/bubble_anchor_util_views.cc.patch
  • src/patches/chrome/browser/ui/views/frame/browser_view.cc.patch
  • src/patches/chrome/browser/ui/views/frame/browser_view.h.patch
  • src/patches/chrome/browser/ui/views/frame/contents_web_view.h.patch
  • src/patches/chrome/browser/ui/views/frame/layout/browser_view_tabbed_layout_impl.cc.patch
  • src/patches/chrome/browser/ui/webui/chrome_web_ui_configs.cc.patch
  • src/patches/chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc.patch
  • src/patches/chrome/browser/ui/webui/settings/settings_ui.cc.patch
  • src/patches/chrome/chrome_paks.gni.patch
  • src/patches/chrome/common/webui_url_constants.h.patch
  • src/patches/chrome/test/BUILD.gn.patch
  • src/patches/chrome/test/data/webui/settings/BUILD.gn.patch
  • src/patches/components/constrained_window/constrained_window_views.cc.patch
  • src/patches/extensions/browser/api/web_request/extension_web_request_event_router.cc.patch
  • src/patches/ui/webui/resources/tools/eslint/BUILD.gn.patch
📝 Walkthrough

Walkthrough

Chromium is updated to 149.0.7827.201. The PR migrates browser discovery to browser collections, adds weekly Dream and external agent actions, expands Dao UI integration, and updates Chromium patches, resources, PiP, QR-code, toast, build, and tooling behavior.

Changes

Dao integration

Layer / File(s) Summary
Chromium baseline and fixtures
dao.json, docs/*, scripts/commands/__tests__/*
Version metadata, documentation, cache examples, and version fixtures now reference Chromium 149.
Dream workflows
src/dao/browser/agent/dao_dream_service.*, dao_weekly_dream_material_collector.cc, dao_dream_browsertest.cc
Daily reruns, failure persistence, text redaction, scheduler tests, and numeric WebUI validation are updated.
Browser collection migration
src/dao/browser/agent/*, src/dao/browser/ui/views/*, src/dao/browser/ui/webui/*
Browser lifecycle observation and browser/tab lookup use profile or global browser collections and migration-only browser accessors.
Dream and agent WebUI integration
src/dao/browser/ui/webui/dao_agent_ui.*, src/dao/browser/ui/views/dao_agent_sidebar_view.*, src/dao/browser/ui/webui/resources/agent/*
Weekly Dream endpoints, source availability checks, external prompt/session hooks, and chat-view actions are added.
Dao browser UI composition
src/patches/chrome/browser/ui/views/frame/*, src/patches/chrome/browser/ui/views/frame/layout/*, src/dao/browser/ui/views/*
Dao views, sidebar layout, overlays, popup anchors, focus handling, hit testing, localization, and background override APIs are integrated.
Chromium features and resources
src/patches/chrome/app/*, src/patches/chrome/browser/*, src/patches/chrome/common/*, src/patches/chrome/chrome_paks.gni.patch
Dao URLs, settings strings, feature flags, macOS commands, force-dark preferences, WebUI registration, and resource packages are updated.
PiP, QR, toast, and dialogs
src/patches/chrome/browser/picture_in_picture/*, src/patches/chrome/browser/renderer_context_menu/*, src/patches/components/constrained_window/*
PiP sizing persistence, QR decoding, Dao toast feedback, and web-content-centered dialogs are implemented.
Build and tooling compatibility
src/patches/chrome/*/BUILD.gn.patch, src/patches/extensions/*, src/patches/ui/webui/resources/tools/eslint/*, src/dao/browser/updater/*
Dao test targets and resources are wired into builds, listener assertions are relaxed, ESLint typing is isolated, startup behavior is adjusted, and observer reentrancy is enabled.

Estimated code review effort: 5 (Critical) | ~120 minutes

Possibly related PRs

  • msgbyte/dao-browser#21: Both PRs modify the weekly Dream material collection pipeline, including redaction and sanitization behavior.
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 3.96% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely summarizes the main change: updating the Chromium base to 149.0.7827.201.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch moonrailgun/dump-to-149

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (4)
src/patches/chrome/browser/app_controller_mac_little_dao_external.mm.patch (1)

42-45: 🎯 Functional Correctness | 🔴 Critical | ⚡ Quick win

Fix GURL scheme accessor.

GURL does not have a GetScheme() method. You should use url.scheme() or url.scheme_piece() to retrieve the scheme.

🐛 Proposed fix
       const bool handled_by_chrome =
           ProfileIOData::IsHandledURL(url) ||
-          (registry && registry->IsHandledProtocol(url.GetScheme()));
+          (registry && registry->IsHandledProtocol(url.scheme()));
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/patches/chrome/browser/app_controller_mac_little_dao_external.mm.patch`
around lines 42 - 45, Update the handled_by_chrome expression to replace the
nonexistent GURL::GetScheme() call with the supported url.scheme() or
url.scheme_piece() accessor when passing the scheme to
registry->IsHandledProtocol.
src/patches/chrome/browser/ui/webui/chrome_web_ui_configs.cc.patch (1)

9-28: 🎯 Functional Correctness | 🔴 Critical | ⚡ Quick win

Add missing #include directives.

You are registering DaoDreamUIConfig, DaoIndexUIConfig, DaoMemoryUIConfig, and DaoSkillsUIConfig, but their corresponding header files are not included in the patch. As per coding guidelines, ensure all #include directives are present to avoid compilation errors due to undeclared identifiers or incomplete types.

🐛 Proposed fix
 `#include` "chrome/browser/ui/webui/chrome_web_ui_configs.h"
 
 `#include` "dao/browser/ui/webui/dao_agent_ui.h"
+#include "dao/browser/ui/webui/dao_dream_ui.h"
+#include "dao/browser/ui/webui/dao_index_ui.h"
+#include "dao/browser/ui/webui/dao_memory_ui.h"
 `#include` "dao/browser/ui/webui/dao_sidebar_ui.h"
+#include "dao/browser/ui/webui/dao_skills_ui.h"
 `#include` "dao/browser/ui/webui/dao_welcome_ui.h"
 
 `#include` "build/android_buildflags.h"
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/patches/chrome/browser/ui/webui/chrome_web_ui_configs.cc.patch` around
lines 9 - 28, Add the missing header includes for DaoDreamUIConfig,
DaoIndexUIConfig, DaoMemoryUIConfig, and DaoSkillsUIConfig alongside the
existing Dao WebUI includes, so every config type registered in
RegisterChromeWebUIConfigs is declared.

Source: Coding guidelines

src/patches/chrome/browser/ui/views/frame/browser_view.cc.patch (1)

312-319: 🎯 Functional Correctness | 🔴 Critical | ⚡ Quick win

Return HTCAPTION to make regions draggable.

Both the sidebar header and Little Dao top bar are intended to be draggable window handles, as explicitly documented in the patch comments. However, returning HTNOWHERE drops the hit-test event at the OS level, rendering these regions completely unclickable and undraggable.

  • src/patches/chrome/browser/ui/views/frame/browser_view.cc.patch#L312-L319: Return HTCAPTION instead of HTNOWHERE so the sidebar header acts as a drag region.
  • src/patches/chrome/browser/ui/views/frame/browser_view.cc.patch#L350-L354: Return HTCAPTION instead of HTNOWHERE so the Little Dao top bar acts as a drag region.
🐛 Proposed fixes

For the sidebar header:

-      return HTNOWHERE;
+      return HTCAPTION;

For the Little Dao top bar:

-      return HTNOWHERE;
+      return HTCAPTION;
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/patches/chrome/browser/ui/views/frame/browser_view.cc.patch` around lines
312 - 319, Replace the HTNOWHERE return in the sidebar header hit-testing branch
with HTCAPTION, and make the same replacement in the Little Dao top bar branch.
Update both affected sites in
src/patches/chrome/browser/ui/views/frame/browser_view.cc.patch: lines 312-319
and 350-354, preserving the existing toggle-button HTCLIENT handling.
src/dao/browser/ui/views/dao_control_center_utility_section.cc (1)

194-237: 📐 Maintainability & Code Quality | 🟠 Major | ⚡ Quick win

Do not hardcode user-facing English strings.

The strings u"QR Code", u"Security", and u"More" are hardcoded in the view code. As per coding guidelines, do not hardcode user-facing English in Dao-owned view code; use the i18n pipelines instead (e.g., l10n_util::GetStringUTF16(IDS_DAO_...)).

Please extract these literal strings into .grd files and invoke them with l10n_util::GetStringUTF16(), matching the behavior of the adjacent "Mini Dao" and "Force Dark Mode" buttons.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/dao/browser/ui/views/dao_control_center_utility_section.cc` around lines
194 - 237, Replace the hardcoded labels u"QR Code", u"Security", and u"More" in
DaoControlCenterUtilitySection with localized IDS_DAO_* resources. Add the
corresponding entries to the appropriate .grd files and construct each
UtilityButton label via l10n_util::GetStringUTF16(), matching the existing Mini
Dao and Force Dark Mode buttons.

Source: Coding guidelines

🧹 Nitpick comments (1)
src/patches/chrome/browser/ui/views/frame/browser_view.cc.patch (1)

219-224: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Prefer LayoutRootViewIfNecessary() over DeprecatedLayoutImmediately().

Both locations invoke DeprecatedLayoutImmediately(), which is a discouraged API being phased out in newer Chromium View architectures. Consider replacing it with the standard layout invalidation flow.

  • src/patches/chrome/browser/ui/views/frame/browser_view.cc.patch#L219-L224: Replace DeprecatedLayoutImmediately() with LayoutRootViewIfNecessary() in OnActiveTabChanged.
  • src/patches/chrome/browser/ui/views/frame/browser_view.cc.patch#L259-L264: Replace DeprecatedLayoutImmediately() with LayoutRootViewIfNecessary() in OnTabChangedAt.
♻️ Proposed fixes

In OnActiveTabChanged:

-    GetWidget()->GetRootView()->DeprecatedLayoutImmediately();
+    GetWidget()->LayoutRootViewIfNecessary();

In OnTabChangedAt:

-    GetWidget()->GetRootView()->DeprecatedLayoutImmediately();
+    GetWidget()->LayoutRootViewIfNecessary();
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/patches/chrome/browser/ui/views/frame/browser_view.cc.patch` around lines
219 - 224, Replace the discouraged DeprecatedLayoutImmediately() call with
LayoutRootViewIfNecessary() in OnActiveTabChanged at
src/patches/chrome/browser/ui/views/frame/browser_view.cc.patch lines 219-224
and in OnTabChangedAt at lines 259-264, preserving the existing layout
invalidation flow.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@src/dao/browser/ui/webui/resources/agent/dao_chat_view.ts`:
- Around line 4926-4931: Update prefillExternalPrompt to wait for mountReady_
before querying panel_ or calling setInput, matching the readiness flow used by
openExternalSession. Preserve the existing empty-text guard, prompt prefilling,
and delayed focus behavior after mounting completes.

In `@src/patches/chrome/app/settings_strings_dao.grdp.patch`:
- Around line 1-4: Align the patch filename with its target by consolidating
this diff into the existing settings_strings.grdp.patch for
chrome/app/settings_strings.grdp, unless the intended target is
settings_strings_dao.grdp; in that case, update the diff headers and content
accordingly. Ensure only one patch owns the settings_strings.grdp changes to
prevent application conflicts.

---

Outside diff comments:
In `@src/dao/browser/ui/views/dao_control_center_utility_section.cc`:
- Around line 194-237: Replace the hardcoded labels u"QR Code", u"Security", and
u"More" in DaoControlCenterUtilitySection with localized IDS_DAO_* resources.
Add the corresponding entries to the appropriate .grd files and construct each
UtilityButton label via l10n_util::GetStringUTF16(), matching the existing Mini
Dao and Force Dark Mode buttons.

In `@src/patches/chrome/browser/app_controller_mac_little_dao_external.mm.patch`:
- Around line 42-45: Update the handled_by_chrome expression to replace the
nonexistent GURL::GetScheme() call with the supported url.scheme() or
url.scheme_piece() accessor when passing the scheme to
registry->IsHandledProtocol.

In `@src/patches/chrome/browser/ui/views/frame/browser_view.cc.patch`:
- Around line 312-319: Replace the HTNOWHERE return in the sidebar header
hit-testing branch with HTCAPTION, and make the same replacement in the Little
Dao top bar branch. Update both affected sites in
src/patches/chrome/browser/ui/views/frame/browser_view.cc.patch: lines 312-319
and 350-354, preserving the existing toggle-button HTCLIENT handling.

In `@src/patches/chrome/browser/ui/webui/chrome_web_ui_configs.cc.patch`:
- Around line 9-28: Add the missing header includes for DaoDreamUIConfig,
DaoIndexUIConfig, DaoMemoryUIConfig, and DaoSkillsUIConfig alongside the
existing Dao WebUI includes, so every config type registered in
RegisterChromeWebUIConfigs is declared.

---

Nitpick comments:
In `@src/patches/chrome/browser/ui/views/frame/browser_view.cc.patch`:
- Around line 219-224: Replace the discouraged DeprecatedLayoutImmediately()
call with LayoutRootViewIfNecessary() in OnActiveTabChanged at
src/patches/chrome/browser/ui/views/frame/browser_view.cc.patch lines 219-224
and in OnTabChangedAt at lines 259-264, preserving the existing layout
invalidation flow.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 57d81ea7-28ca-4a0d-937d-7263df0c6369

📥 Commits

Reviewing files that changed from the base of the PR and between 4cb4029 and 356917a.

📒 Files selected for processing (61)
  • dao.json
  • docs/features.md
  • docs/worktree-engine-cache.md
  • scripts/commands/__tests__/import.test.ts
  • scripts/commands/__tests__/release.test.ts
  • src/dao/browser/agent/dao_agent_proactive_engine.cc
  • src/dao/browser/agent/dao_agent_proactive_engine.h
  • src/dao/browser/agent/dao_dream_browsertest.cc
  • src/dao/browser/agent/dao_dream_service.cc
  • src/dao/browser/agent/dao_dream_service.h
  • src/dao/browser/agent/dao_weekly_dream_material_collector.cc
  • src/dao/browser/extensions/legacy_mv2/dao_mv2_browsertest.cc
  • src/dao/browser/ui/views/dao_agent_sidebar_view.cc
  • src/dao/browser/ui/views/dao_agent_sidebar_view.h
  • src/dao/browser/ui/views/dao_browser_browsertest.cc
  • src/dao/browser/ui/views/dao_command_bar_view.cc
  • src/dao/browser/ui/views/dao_control_center_extensions_section.cc
  • src/dao/browser/ui/views/dao_control_center_utility_section.cc
  • src/dao/browser/ui/views/dao_cross_window_drag.cc
  • src/dao/browser/ui/views/dao_native_util_mac.mm
  • src/dao/browser/ui/views/dao_pinned_extensions_container.cc
  • src/dao/browser/ui/views/little_dao/dao_little_dao_controller.cc
  • src/dao/browser/ui/views/little_dao/dao_mini_dao_site_center_popup.cc
  • src/dao/browser/ui/views/sidebar/dao_sidebar_view.cc
  • src/dao/browser/ui/views/split/dao_split_view.cc
  • src/dao/browser/ui/webui/dao_agent_ui.cc
  • src/dao/browser/ui/webui/dao_agent_ui.h
  • src/dao/browser/ui/webui/dao_sidebar_ui.cc
  • src/dao/browser/ui/webui/resources/agent/__tests__/dao_agent_app.test.ts
  • src/dao/browser/ui/webui/resources/agent/dao_agent_app.ts
  • src/dao/browser/ui/webui/resources/agent/dao_chat_view.ts
  • src/dao/browser/updater/dao_updater_service.cc
  • src/patches/chrome/app/generated_resources.grd.patch
  • src/patches/chrome/app/settings_strings.grdp.patch
  • src/patches/chrome/app/settings_strings_dao.grdp.patch
  • src/patches/chrome/browser/about_flags.cc.patch
  • src/patches/chrome/browser/app_controller_mac.mm.patch
  • src/patches/chrome/browser/app_controller_mac_little_dao_external.mm.patch
  • src/patches/chrome/browser/chrome_browser_main_mac.mm.patch
  • src/patches/chrome/browser/chrome_content_browser_client_force_dark_mode.cc.patch
  • src/patches/chrome/browser/picture_in_picture/picture_in_picture_window_manager.cc.patch
  • src/patches/chrome/browser/renderer_context_menu/render_view_context_menu.cc.patch
  • src/patches/chrome/browser/renderer_context_menu/render_view_context_menu_browsertest.cc.patch
  • src/patches/chrome/browser/ui/BUILD.gn.patch
  • src/patches/chrome/browser/ui/browser_live_tab_context.cc.patch
  • src/patches/chrome/browser/ui/startup/infobar_utils.cc.patch
  • src/patches/chrome/browser/ui/views/bubble_anchor_util_views.cc.patch
  • src/patches/chrome/browser/ui/views/frame/browser_view.cc.patch
  • src/patches/chrome/browser/ui/views/frame/browser_view.h.patch
  • src/patches/chrome/browser/ui/views/frame/contents_web_view.h.patch
  • src/patches/chrome/browser/ui/views/frame/layout/browser_view_tabbed_layout_impl.cc.patch
  • src/patches/chrome/browser/ui/webui/chrome_web_ui_configs.cc.patch
  • src/patches/chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc.patch
  • src/patches/chrome/browser/ui/webui/settings/settings_ui.cc.patch
  • src/patches/chrome/chrome_paks.gni.patch
  • src/patches/chrome/common/webui_url_constants.h.patch
  • src/patches/chrome/test/BUILD.gn.patch
  • src/patches/chrome/test/data/webui/settings/BUILD.gn.patch
  • src/patches/components/constrained_window/constrained_window_views.cc.patch
  • src/patches/extensions/browser/api/web_request/extension_web_request_event_router.cc.patch
  • src/patches/ui/webui/resources/tools/eslint/BUILD.gn.patch
👮 Files not reviewed due to content moderation or server errors (10)
  • src/dao/browser/agent/dao_dream_browsertest.cc
  • src/dao/browser/agent/dao_dream_service.h
  • src/dao/browser/agent/dao_dream_service.cc
  • src/dao/browser/agent/dao_weekly_dream_material_collector.cc
  • src/dao/browser/ui/webui/dao_agent_ui.cc
  • src/dao/browser/ui/webui/dao_agent_ui.h
  • src/dao/browser/ui/views/dao_agent_sidebar_view.cc
  • src/dao/browser/ui/views/dao_agent_sidebar_view.h
  • src/dao/browser/ui/webui/resources/agent/tests/dao_agent_app.test.ts
  • src/dao/browser/ui/webui/resources/agent/dao_agent_app.ts

Comment thread src/dao/browser/ui/webui/resources/agent/dao_chat_view.ts Outdated
Comment on lines 1 to 4
diff --git a/chrome/app/settings_strings.grdp b/chrome/app/settings_strings.grdp
index d9e3f457c1..0000000002 100644
index aae688f787f30..d7ddfe3e08b71 100644
--- a/chrome/app/settings_strings.grdp
+++ b/chrome/app/settings_strings.grdp

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📐 Maintainability & Code Quality | 🟠 Major | ⚡ Quick win

Mismatch between patch filename and the patched file.

The patch file is named settings_strings_dao.grdp.patch, but its diff header indicates it modifies chrome/app/settings_strings.grdp. As per coding guidelines, patch files under src/patches/ should mirror Chromium's directory structure.

If this is meant to patch settings_strings.grdp, it should be consolidated with src/patches/chrome/app/settings_strings.grdp.patch to avoid conflicts during patch application. If it's meant to create or patch a new settings_strings_dao.grdp file, the diff header (and potentially the patch content) needs to be updated.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/patches/chrome/app/settings_strings_dao.grdp.patch` around lines 1 - 4,
Align the patch filename with its target by consolidating this diff into the
existing settings_strings.grdp.patch for chrome/app/settings_strings.grdp,
unless the intended target is settings_strings_dao.grdp; in that case, update
the diff headers and content accordingly. Ensure only one patch owns the
settings_strings.grdp changes to prevent application conflicts.

Source: Coding guidelines

@moonrailgun
moonrailgun force-pushed the moonrailgun/dump-to-149 branch from 356917a to 95015e2 Compare July 22, 2026 03:03

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@scripts/commands/__tests__/release.test.ts`:
- Line 75: Update the fixture’s info.json.chromiumVersion value alongside the
version in the release test fixture to 149.0.7827.201, keeping both Chromium
metadata fields consistent.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: b4cbe13d-cbbb-4f4e-a699-93a3096cb7b1

📥 Commits

Reviewing files that changed from the base of the PR and between 356917a and 95015e2.

📒 Files selected for processing (61)
  • dao.json
  • docs/features.md
  • docs/worktree-engine-cache.md
  • scripts/commands/__tests__/import.test.ts
  • scripts/commands/__tests__/release.test.ts
  • src/dao/browser/agent/dao_agent_proactive_engine.cc
  • src/dao/browser/agent/dao_agent_proactive_engine.h
  • src/dao/browser/agent/dao_dream_browsertest.cc
  • src/dao/browser/agent/dao_dream_service.cc
  • src/dao/browser/agent/dao_dream_service.h
  • src/dao/browser/agent/dao_weekly_dream_material_collector.cc
  • src/dao/browser/extensions/legacy_mv2/dao_mv2_browsertest.cc
  • src/dao/browser/ui/views/dao_agent_sidebar_view.cc
  • src/dao/browser/ui/views/dao_agent_sidebar_view.h
  • src/dao/browser/ui/views/dao_browser_browsertest.cc
  • src/dao/browser/ui/views/dao_command_bar_view.cc
  • src/dao/browser/ui/views/dao_control_center_extensions_section.cc
  • src/dao/browser/ui/views/dao_control_center_utility_section.cc
  • src/dao/browser/ui/views/dao_cross_window_drag.cc
  • src/dao/browser/ui/views/dao_native_util_mac.mm
  • src/dao/browser/ui/views/dao_pinned_extensions_container.cc
  • src/dao/browser/ui/views/little_dao/dao_little_dao_controller.cc
  • src/dao/browser/ui/views/little_dao/dao_mini_dao_site_center_popup.cc
  • src/dao/browser/ui/views/sidebar/dao_sidebar_view.cc
  • src/dao/browser/ui/views/split/dao_split_view.cc
  • src/dao/browser/ui/webui/dao_agent_ui.cc
  • src/dao/browser/ui/webui/dao_agent_ui.h
  • src/dao/browser/ui/webui/dao_sidebar_ui.cc
  • src/dao/browser/ui/webui/resources/agent/__tests__/dao_agent_app.test.ts
  • src/dao/browser/ui/webui/resources/agent/dao_agent_app.ts
  • src/dao/browser/ui/webui/resources/agent/dao_chat_view.ts
  • src/dao/browser/updater/dao_updater_service.cc
  • src/patches/chrome/app/generated_resources.grd.patch
  • src/patches/chrome/app/settings_strings.grdp.patch
  • src/patches/chrome/app/settings_strings_dao.grdp.patch
  • src/patches/chrome/browser/about_flags.cc.patch
  • src/patches/chrome/browser/app_controller_mac.mm.patch
  • src/patches/chrome/browser/app_controller_mac_little_dao_external.mm.patch
  • src/patches/chrome/browser/chrome_browser_main_mac.mm.patch
  • src/patches/chrome/browser/chrome_content_browser_client_force_dark_mode.cc.patch
  • src/patches/chrome/browser/picture_in_picture/picture_in_picture_window_manager.cc.patch
  • src/patches/chrome/browser/renderer_context_menu/render_view_context_menu.cc.patch
  • src/patches/chrome/browser/renderer_context_menu/render_view_context_menu_browsertest.cc.patch
  • src/patches/chrome/browser/ui/BUILD.gn.patch
  • src/patches/chrome/browser/ui/browser_live_tab_context.cc.patch
  • src/patches/chrome/browser/ui/startup/infobar_utils.cc.patch
  • src/patches/chrome/browser/ui/views/bubble_anchor_util_views.cc.patch
  • src/patches/chrome/browser/ui/views/frame/browser_view.cc.patch
  • src/patches/chrome/browser/ui/views/frame/browser_view.h.patch
  • src/patches/chrome/browser/ui/views/frame/contents_web_view.h.patch
  • src/patches/chrome/browser/ui/views/frame/layout/browser_view_tabbed_layout_impl.cc.patch
  • src/patches/chrome/browser/ui/webui/chrome_web_ui_configs.cc.patch
  • src/patches/chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc.patch
  • src/patches/chrome/browser/ui/webui/settings/settings_ui.cc.patch
  • src/patches/chrome/chrome_paks.gni.patch
  • src/patches/chrome/common/webui_url_constants.h.patch
  • src/patches/chrome/test/BUILD.gn.patch
  • src/patches/chrome/test/data/webui/settings/BUILD.gn.patch
  • src/patches/components/constrained_window/constrained_window_views.cc.patch
  • src/patches/extensions/browser/api/web_request/extension_web_request_event_router.cc.patch
  • src/patches/ui/webui/resources/tools/eslint/BUILD.gn.patch
🚧 Files skipped from review as they are similar to previous changes (58)
  • src/patches/chrome/test/data/webui/settings/BUILD.gn.patch
  • src/dao/browser/ui/views/dao_control_center_utility_section.cc
  • src/patches/chrome/browser/ui/views/bubble_anchor_util_views.cc.patch
  • src/dao/browser/ui/views/dao_pinned_extensions_container.cc
  • src/dao/browser/agent/dao_dream_service.h
  • scripts/commands/tests/import.test.ts
  • docs/worktree-engine-cache.md
  • src/dao/browser/ui/webui/dao_agent_ui.h
  • src/dao/browser/ui/views/dao_agent_sidebar_view.h
  • src/dao/browser/updater/dao_updater_service.cc
  • src/dao/browser/ui/views/dao_command_bar_view.cc
  • src/patches/chrome/chrome_paks.gni.patch
  • src/dao/browser/extensions/legacy_mv2/dao_mv2_browsertest.cc
  • src/dao/browser/ui/views/little_dao/dao_mini_dao_site_center_popup.cc
  • src/patches/chrome/browser/chrome_browser_main_mac.mm.patch
  • dao.json
  • src/patches/chrome/browser/app_controller_mac_little_dao_external.mm.patch
  • src/patches/extensions/browser/api/web_request/extension_web_request_event_router.cc.patch
  • src/patches/chrome/browser/ui/webui/settings/settings_ui.cc.patch
  • src/dao/browser/ui/views/dao_control_center_extensions_section.cc
  • src/patches/chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc.patch
  • src/patches/chrome/browser/about_flags.cc.patch
  • src/patches/chrome/browser/ui/browser_live_tab_context.cc.patch
  • src/patches/chrome/app/settings_strings_dao.grdp.patch
  • src/dao/browser/ui/views/dao_native_util_mac.mm
  • src/dao/browser/agent/dao_agent_proactive_engine.cc
  • src/dao/browser/ui/views/sidebar/dao_sidebar_view.cc
  • src/dao/browser/ui/webui/resources/agent/tests/dao_agent_app.test.ts
  • src/patches/ui/webui/resources/tools/eslint/BUILD.gn.patch
  • src/dao/browser/agent/dao_agent_proactive_engine.h
  • src/dao/browser/agent/dao_weekly_dream_material_collector.cc
  • src/patches/chrome/browser/renderer_context_menu/render_view_context_menu.cc.patch
  • src/patches/chrome/browser/ui/startup/infobar_utils.cc.patch
  • src/dao/browser/ui/webui/resources/agent/dao_chat_view.ts
  • src/dao/browser/ui/views/dao_agent_sidebar_view.cc
  • src/patches/chrome/app/settings_strings.grdp.patch
  • src/dao/browser/ui/webui/dao_sidebar_ui.cc
  • src/patches/chrome/test/BUILD.gn.patch
  • src/patches/chrome/browser/app_controller_mac.mm.patch
  • src/patches/chrome/browser/ui/BUILD.gn.patch
  • src/patches/chrome/browser/chrome_content_browser_client_force_dark_mode.cc.patch
  • docs/features.md
  • src/dao/browser/ui/webui/resources/agent/dao_agent_app.ts
  • src/patches/components/constrained_window/constrained_window_views.cc.patch
  • src/patches/chrome/browser/renderer_context_menu/render_view_context_menu_browsertest.cc.patch
  • src/patches/chrome/browser/ui/views/frame/contents_web_view.h.patch
  • src/patches/chrome/browser/ui/views/frame/layout/browser_view_tabbed_layout_impl.cc.patch
  • src/patches/chrome/browser/ui/views/frame/browser_view.cc.patch
  • src/patches/chrome/common/webui_url_constants.h.patch
  • src/dao/browser/ui/views/little_dao/dao_little_dao_controller.cc
  • src/patches/chrome/browser/picture_in_picture/picture_in_picture_window_manager.cc.patch
  • src/patches/chrome/browser/ui/webui/chrome_web_ui_configs.cc.patch
  • src/patches/chrome/browser/ui/views/frame/browser_view.h.patch
  • src/dao/browser/ui/views/split/dao_split_view.cc
  • src/dao/browser/ui/views/dao_browser_browsertest.cc
  • src/dao/browser/agent/dao_dream_service.cc
  • src/patches/chrome/app/generated_resources.grd.patch
  • src/dao/browser/ui/webui/dao_agent_ui.cc

Comment thread scripts/commands/__tests__/release.test.ts
@moonrailgun
moonrailgun force-pushed the moonrailgun/dump-to-149 branch from 4f69e98 to adef776 Compare July 22, 2026 15:44
@moonrailgun
moonrailgun merged commit cf93ef5 into main Jul 22, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant