@W-23692110: Harden multi-engine lifecycle and streaming - #177
Draft
mlischetti wants to merge 44 commits into
Draft
@W-23692110: Harden multi-engine lifecycle and streaming#177mlischetti wants to merge 44 commits into
mlischetti wants to merge 44 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This draft layers the first completed PR #157 review-22 remediations onto
w-23692110-multi-engine-design. It does not targetmaster.Completed through Task 5:
LIVE -> CLOSING -> DESTROYEDengine lifecycle records and operation leases;destroy_engineclose admission and drain admitted operations;ScriptRuntime.get(long)lookup;{handle, generation}tokens;Intentional Contracts
destroy_enginemay block until all previously admitted operations finish.destroy_enginereturns.DataWeaveErrorbefore lock acquisition or native attachment.Verification
JAVA_HOME=<GraalVM 24> GRAALVM_HOME=<GraalVM 24> ./gradlew native-lib:test -PskipNodeTests=true -PskipPythonTests=truepython3 -m pytest -m unit -q168 passed, 75 deselected.DATAWEAVE_NATIVE_LIB=../build/native/nativeCompile/dwlib.dylib python3 -m pytest tests/integration/test_lifecycle.py tests/integration/test_module_resolver.py tests/integration/test_streaming.py -q28 passed.4 passed.4 passed.git diff --check origin/w-23692110-multi-engine-design...HEADThe Python unit suite currently has a pre-existing approximately 30-second process-exit delay after reporting success. It was isolated to an older streaming cleanup test with a non-daemon consumer and reproduces before these changes.
Remaining Draft Work
Relationship To PR #157
This is a focused follow-up branch for the eight findings from PR #157 review 22. The PR remains draft until the remaining Node, documentation, and final verification tasks are complete.