Fix getElementRadius returning false for buildings - #5138
Merged
FileEX merged 1 commit intoAug 2, 2026
Conversation
FileEX
approved these changes
Aug 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getElementRadius's type switch never had a case for buildings; it fell through to the final
return false, even thoughCClientBuildingalready exposesGetModel()the same way objects and peds do. Added the missing case, same pattern already used right below it inGetElementDistanceFromCentreOfMassToBaseOfModel.Motivation
Fixes #5137.
Test plan
Created a building with
createBuilding, calledgetElementRadiuson it; now returns the model's bounding radius instead offalse. Also re-testedgetElementRadiuson a ped, vehicle and object to confirm the existing cases are untouched.Checklist