Skip to content

Add glob support for map files - #5143

Open
efejotaese2 wants to merge 2 commits into
multitheftauto:masterfrom
efejotaese2:feature/map-glob
Open

Add glob support for map files#5143
efejotaese2 wants to merge 2 commits into
multitheftauto:masterfrom
efejotaese2:feature/map-glob

Conversation

@efejotaese2

Copy link
Copy Markdown

Summary

Adds glob support for <map> entries in meta.xml, using the existing resource file glob handling.

For example:

<map src="maps/*.map" dimension="0" />
<map src="maps/**/*.map" dimension="0" />
<map src="*.map" dimension="0" />

All matching map files are loaded with the attributes defined on the <map> node.

Motivation

<script> and <file> entries already support glob patterns, while <map> entries currently require an explicit file path.

This resolves #4902.

Test plan

Tested:
Multiple .map files using *.map.
Recursive **/*.map
Glob with no matches
Normal paths

In all cases, the resource behaved as expected and matching map files were loaded correctly.

Checklist

  • Your code should follow the coding guidelines.
  • Smaller pull requests are easier to review. If your pull request is beefy, your pull request should be reviewable commit-by-commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Glob to .map

2 participants