Skip to content

Linux file picker can select several files - #243

Draft
saintmatthieu wants to merge 1 commit into
musescore:mainfrom
saintmatthieu:11753-linux-file-picker-multi-selection
Draft

Linux file picker can select several files#243
saintmatthieu wants to merge 1 commit into
musescore:mainfrom
saintmatthieu:11753-linux-file-picker-multi-selection

Conversation

@saintmatthieu

Copy link
Copy Markdown
Contributor

Resolves: audacity/audacity#11753

  • I signed the CLA as username:
  • The title of the PR describes the problem it addresses.
  • Each commit's message describes its purpose and effects, and references the issue it resolves. If changes are extensive, there is a sequence of easily reviewable commits.
  • The code in the PR follows the coding rules.
  • I understand all aspects of the code I'm contributing and I'm able to explain it if requested.
  • The code compiles and runs on my machine, preferably after each commit individually. I have manually tested and verified that my changes fulfil their intended purpose.
  • No prior attempts to resolve this problem exist, or if they do, I listed them in my PR description and described how I avoided repeating past mistakes.
  • There are no unnecessary changes.
  • I created a unit test or vtest to verify the changes I made (if applicable).

Build configuration

audacity: audacity/audacity/master
audacity platforms: linux_x64
musescore: musescore/MuseScore/main
musescore platforms: linux_x64

@saintmatthieu saintmatthieu self-assigned this Aug 24, 2026
@saintmatthieu
saintmatthieu marked this pull request as draft August 24, 2026 09:45
@coderabbitai

coderabbitai Bot commented Aug 24, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 86980109-8dd8-4518-b35f-a08bd50040ad

📥 Commits

Reviewing files that changed from the base of the PR and between 85d12c9 and a419398.

📒 Files selected for processing (2)
  • framework/interactive/internal/interactive.cpp
  • framework/interactive/qml/Muse/Interactive/FileDialog.qml

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

Linux selectOpeningFilesSync now opens the interactive file dialog in OpenFiles mode through openSync. It returns an empty path list when the operation fails. On success, it converts returned URL values into local file paths. The QML OpenFiles handler now reads selections from root.files, converts each URL to a string, and assigns the resulting array to root.ret.value.

Merge Risk: ⚪ Minimal · up to a4193

This localized change enables multi-file selection in the Linux file picker, and no actionable merge-blocking risk remains beyond normal checks and review.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The issue link and build configuration are present, but the motivation is missing and all required checklist items remain unchecked. Add a short change summary and complete each applicable checklist item before merging.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the primary change: enabling multiple file selection in the Linux file picker.
Linked Issues check ✅ Passed The changes implement Linux multi-file selection by opening the multi-file dialog and returning all selected local paths for issue #11753.
Out of Scope Changes check ✅ Passed The changes are limited to the Linux file picker implementation and its QML result conversion, with no unrelated code changes.
Docstring Coverage ✅ Passed Docstring check was indeterminate for this PR — some files could not be analyzed in time. Not blocking.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Linux: file picker only allows selecting one file

1 participant