added rcommand params

[igorkorsukov]

Previously, the dispatcher was essentially a query-first approach, now it's command+params
see also: https://github.com/musescore/muse_framework/blob/main/docs/adr/00104-Command-first.md

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 0a36e8c0-ea2e-4ad0-921d-cf9f0f895c94

📥 Commits

Reviewing files that changed from the base of the PR and between d8923af and 1f186bf.

📒 Files selected for processing (2)

• framework/dockwindow/internal/dockwindowactionscontroller.cpp
• framework/dockwindow/internal/dockwindowactionscontroller.h

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.

---

📝 Walkthrough

Walkthrough

The command framework now represents requests with separate Command and Params values. Dispatcher callbacks and overloads pass parameter maps directly. Dock window and workspace handlers use Params for argument access. Audio seek and MMC locate dispatch rewind commands directly. Diagnostic action-query commands, registrations, mappings, and handlers were removed.

Merge Risk: ⚪ Minimal · up to 1f186

The command-parameter dispatch changes have no identified merge-blocking risk at the current head and are merge-ready after normal checks and review.

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The description states the main technical change and references ADR 00104, but it omits the required issue reference and leaves the required checklist incomplete.	Add a Resolves: #NNNNN issue reference, provide the change motivation, and complete each applicable checklist item in the repository template.
Docstring Coverage	⚠️ Warning	Docstring coverage is 3.03% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 33 functions across 13 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title identifies the addition of rcommand parameters and relates to the main dispatcher refactor. It is concise, although it does not mention the command-first dispatcher change explicitly.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

• Fix all pre-merge checks with AI

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}