Add Apple container local development workflow - #310
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 80789be3e8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| # CI mode permits an empty Turnstile key, which disables it for this local | ||
| # development deployment. | ||
| CI=1 bash k8/generate.sh "$IMAGE_TAG" | ||
| kubectl --context "$CLUSTER_NAME" apply -f k8/ |
There was a problem hiding this comment.
After the documented build ...; deploy iteration sequence, the rebuilt image is loaded under the same fixed tag, while this apply submits an unchanged pod template (k8/frontend-deployment.yaml.tpl:18-22 and the other application templates use that tag with IfNotPresent). Kubernetes therefore leaves the existing deployment pods running, and rollout status merely reports the old revision as ready, so frontend/control-service changes are not actually redeployed. Restart the affected workloads, recycle worker pods, or generate a unique tag for each build.
Useful? React with 👍 / 👎.
80789be to
bc86e44
Compare
bc86e44 to
2c1d61b
Compare
1 participant
Summary
linux/arm64application images and loads them directly into ApplecontainerKubernetes, without a registry push.This uses the worker-language selector added by #309 so the local profile does not create unused Java, Python, or .NET worker pods.
Testing
bash -n k8/apple-container.sh,git diff --check,go test ./..., andgo build ./....rustfs/rustfs:1.0.0-rc.5successfully forlinux/arm64with Applecontainer.upfrom a clean cluster: all service pods and the JavaScript worker reached Ready using only locally loaded ARM64 images.192.168.64.2to192.168.64.4, all pods recovered, and the same HTTP and API E2E checks passed again.Initial cluster creation works with the released Apple plugin. The linked Apple change is only needed when restarting a cluster whose VM address changed.